<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"> Landwerlin, Lionel G
<br>
<b>Sent:</b> Wednesday, October 05, 2016 9:55 AM<br>
<b>To:</b> Jason Ekstrand <jason@jlekstrand.net><br>
<b>Cc:</b> mesa-dev@lists.freedesktop.org; Gandikota, Sirisha <sirisha.gandikota@intel.com><br>
<b>Subject:</b> Re: [Mesa-dev] [PATCH v3 3/5] intel: aubinator: generate a standalone binary<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 05/10/16 17:07, Jason Ekstrand wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
+$(builddir)/%_aubinator_xml.h: $(srcdir)/../genxml/%.xml Makefile<br>
+ $(MKDIR_GEN)<br>
+ $(AM_V_GEN) echo -n "static const uint8_t " > $@; \<br>
+ echo -n `basename $@` | sed -e 's,_aubinator_xml.h,,' >> $@; \<br>
+ echo "_xml[] = {" >> $@; \<br>
+ cat $< | $(XXD) -i >> $@; \<br>
+ echo "};" >> $@<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">I talked to Sirisha a bit yesterday and she wasn't terribly happy with the way this "dirtied" things. I *think* what she didn't like was the piles of autogenerated files it dumps in the tools directory. Sirisha,
please correct me if I'm misunderstanding you.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">One option would be to generate them in the genxml directory as genN_xml.h. We already have genN_pack.h, so it's no big deal to dump more there. Another option would be to add a genxml_include directory to
tools/ and dump them there to get them out of the way.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Personally, I don't think it's a big deal, but I'm also ok with trying to keep things clean.<o:p></o:p></p>
</div>
</blockquote>
<p>Ok, I'll move that to genxml/ if Sirisha is alright with that.<o:p></o:p></p>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">[SG] genxml/ seems to be the most logical place for the files. Yeah, I downloaded the patches and tried to work with the code, and those generated files were distracting to
me. While the idea behind doing that is good, I just prefer a cleaner way to do it.
</span><span style="font-size:11.0pt;font-family:Wingdings;color:windowtext">J</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><o:p></o:p></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">One other question, I got your patch to aubdump in intel-gpu-tools from intel-gfx mailing list in addition to the mesa patches, and ran intel_aubdump -c '/path/to/aubinator
--gen=hsw' glxgears. I was able to see the glxgears run but I was also expecting the output from aubinator on my terminal. Was that not the intended usecase for this? Or am I expecting the wrong thing from this feature?<o:p></o:p></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">Thanks<o:p></o:p></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">Sirisha<o:p></o:p></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><o:p> </o:p></span></p>
</div>
</div>
</body>
</html>