<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">I should mentioned that in the commit
      message, but as far as I can tell, looking at the CTS, it doesn't
      seem to ever set the anisotropy value on the sampler to something
      other than 1.0f.<br>
      <br>
      I really need to get the details from Mark about the CI...<br>
      <br>
      On 07/10/16 17:52, Jason Ekstrand wrote:<br>
    </div>
    <blockquote
cite="mid:CAOFGe954x++=+_GFvvMePLipkfNhe_=onPjr6+Ff_nGbUY_r-Q@mail.gmail.com"
      type="cite">
      <p dir="ltr">Does this enable more tests?  If so, do we pass them?</p>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Oct 7, 2016 9:50 AM, "Lionel
          Landwerlin" <<a moz-do-not-send="true"
            href="mailto:llandwerlin@gmail.com">llandwerlin@gmail.com</a>>
          wrote:<br type="attribution">
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">According
            to the Vulkan spec 5.63.4 :<br>
            <br>
              samplerAnisotropy indicates whether anisotropic filtering
            is supported. If<br>
              this feature is not enabled, the maxAnisotropy member of
            the<br>
              VkSamplerCreateInfo structure must be 1.0.<br>
            <br>
            Since we already set maxAnisotropy to 16 and program the
            hardware according<br>
            to the VkSamplerCreateInfo.<wbr>maxAnisotropy, it seems we
            can turn this on.<br>
            <br>
            Signed-off-by: Lionel Landwerlin <<a
              moz-do-not-send="true"
              href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a><wbr>><br>
            ---<br>
             src/intel/vulkan/TODO         | 1 -<br>
             src/intel/vulkan/anv_device.c | 2 +-<br>
             2 files changed, 1 insertion(+), 2 deletions(-)<br>
            <br>
            diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO<br>
            index 8fac370..dad9fc8 100644<br>
            --- a/src/intel/vulkan/TODO<br>
            +++ b/src/intel/vulkan/TODO<br>
            @@ -5,7 +5,6 @@ Missing Features:<br>
              - FP64<br>
              - Tessellation<br>
              - Cull and Clip Distance<br>
            - - Sampler anisotropy (Is there anything to do here?)<br>
              - Image Gather Extended<br>
              - Storage Image Without Format<br>
              - Investigate CTS failures on HSW<br>
            diff --git a/src/intel/vulkan/anv_device.<wbr>c
            b/src/intel/vulkan/anv_device.<wbr>c<br>
            index c7b9979..502955c 100644<br>
            --- a/src/intel/vulkan/anv_device.<wbr>c<br>
            +++ b/src/intel/vulkan/anv_device.<wbr>c<br>
            @@ -418,7 +418,7 @@ void anv_GetPhysicalDeviceFeatures(<br>
                   .largePoints                              = true,<br>
                   .alphaToOne                               = true,<br>
                   .multiViewport                            = true,<br>
            -      .samplerAnisotropy                        = false, /*
            FINISHME */<br>
            +      .samplerAnisotropy                        = true,<br>
                   .textureCompressionETC2                   =
            pdevice->info.gen >= 8 ||<br>
                                                             
             pdevice->info.is_baytrail,<br>
                   .textureCompressionASTC_LDR               =
            pdevice->info.gen >= 9, /* FINISHME CHV */<br>
            --<br>
            2.9.3<br>
            <br>
            ______________________________<wbr>_________________<br>
            mesa-dev mailing list<br>
            <a moz-do-not-send="true"
              href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
            <a moz-do-not-send="true"
              href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev"
              rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
          </blockquote>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
  </body>
</html>