<p dir="ltr">Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></p>
<p dir="ltr">Marek</p>
<div class="gmail_extra"><br><div class="gmail_quote">On Oct 15, 2016 1:37 AM, "Eric Anholt" <<a href="mailto:eric@anholt.net">eric@anholt.net</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">DEQP's clear tests like to give us x + w < 0 or y + h < 0. Since we<br>
were comparing to an unsigned, it would get promoted to unsigned and come<br>
out as bignum >= width or height and we would clear the whole fb instead<br>
of none of the fb.<br>
<br>
Fixes 10 tests under deqp-gles2/functional/color_<wbr>clear.<br>
---<br>
src/mesa/state_tracker/st_cb_<wbr>clear.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/mesa/state_tracker/st_<wbr>cb_clear.c b/src/mesa/state_tracker/st_<wbr>cb_clear.c<br>
index 813ba9b10ffa..158efc186c05 100644<br>
--- a/src/mesa/state_tracker/st_<wbr>cb_clear.c<br>
+++ b/src/mesa/state_tracker/st_<wbr>cb_clear.c<br>
@@ -318,8 +318,8 @@ is_scissor_enabled(struct gl_context *ctx, struct gl_renderbuffer *rb)<br>
return (ctx->Scissor.EnableFlags & 1) &&<br>
(scissor->X > 0 ||<br>
scissor->Y > 0 ||<br>
- scissor->X + scissor->Width < rb->Width ||<br>
- scissor->Y + scissor->Height < rb->Height);<br>
+ scissor->X + scissor->Width < (int)rb->Width ||<br>
+ scissor->Y + scissor->Height < (int)rb->Height);<br>
}<br>
<br>
/**<br>
--<br>
2.9.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div>