<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Concurrent call to glClientWaitSync results in segfault in one of the waiters."
href="https://bugs.freedesktop.org/show_bug.cgi?id=98172#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Concurrent call to glClientWaitSync results in segfault in one of the waiters."
href="https://bugs.freedesktop.org/show_bug.cgi?id=98172">bug 98172</a>
from <span class="vcard"><a class="email" href="mailto:michel@daenzer.net" title="Michel Dänzer <michel@daenzer.net>"> <span class="fn">Michel Dänzer</span></a>
</span></b>
<pre>(In reply to shinji.suzuki from <a href="show_bug.cgi?id=98172#c16">comment #16</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=127317" name="attach_127317" title="Arbitration on so->fence through per sync-object mutex.">attachment 127317</a> <a href="attachment.cgi?id=127317&action=edit" title="Arbitration on so->fence through per sync-object mutex.">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=98172&attachment=127317'>[review]</a> [review]
> Arbitration on so->fence through per sync-object mutex.</span >
One minor comment below, otherwise looks good to me. Feel free to submit the
patch generated by git format-patch to the mesa-dev mailing list for review.
+ if (type == GL_SYNC_FENCE) {
+ struct st_sync_object * so =
+ (struct st_sync_object*)CALLOC_STRUCT(st_sync_object);
+ mtx_init(&so->mtx, mtx_plain);
+ return (struct gl_sync_object *)so;
+ } else
return NULL;
This can be written as:
if (type == GL_SYNC_FENCE) {
[...]
}
return NULL;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>