<div dir="ltr"><div>Even though this patch series is from-scratch, Ben deserves most of the credit for tracking this down. He had a series some time ago to fix the issue for the terrain tests but it never ended up landing for a variety of reasons (many of which were stupid). Ben, would you like me to credit you somehow? Maybe a Reported-by?<br><br></div>--Jason<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 24, 2016 at 3:29 PM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">These restrictions existed because intel_miptree_blit couldn't handle<br>
surfaces bigger than 32k. How that we're chopping blits up into chunks, it<br>
can handle any size we throw at it so we can get rid of this restriction.<br>
This improves the terrain tests in synmark by 25-30% on my Sky Lake gt3.<br>
<br>
Signed-off-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br>
---<br>
src/mesa/drivers/dri/i965/brw_<wbr>tex_layout.c | 3 +--<br>
src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c | 6 ------<br>
2 files changed, 1 insertion(+), 8 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_tex_layout.c b/src/mesa/drivers/dri/i965/<wbr>brw_tex_layout.c<br>
index 4618bc0..768f8a8 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>brw_tex_layout.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>brw_tex_layout.c<br>
@@ -610,8 +610,7 @@ brw_miptree_choose_tiling(<wbr>struct brw_context *brw,<br>
if (minimum_pitch < 64)<br>
return I915_TILING_NONE;<br>
<br>
- if (ALIGN(minimum_pitch, 512) >= 32768 ||<br>
- mt->total_width >= 32768 || mt->total_height >= 32768) {<br>
+ if (ALIGN(minimum_pitch, 512) >= 32768) {<br>
perf_debug("%dx%d miptree too large to blit, falling back to untiled",<br>
mt->total_width, mt->total_height);<br>
return I915_TILING_NONE;<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
index 551df4d..551812a 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
@@ -2838,12 +2838,6 @@ static bool<br>
can_blit_slice(struct intel_mipmap_tree *mt,<br>
unsigned int level, unsigned int slice)<br>
{<br>
- uint32_t image_x;<br>
- uint32_t image_y;<br>
- intel_miptree_get_image_<wbr>offset(mt, level, slice, &image_x, &image_y);<br>
- if (image_x >= 32768 || image_y >= 32768)<br>
- return false;<br>
-<br>
/* See intel_miptree_blit() for details on the 32k pitch limit. */<br>
if (mt->pitch >= 32768)<br>
return false;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.5.0.400.gff86faf<br>
<br>
</font></span></blockquote></div><br></div>