<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - GLES3.1 link negative dEQP "expected linking to fail, but passed."" href="https://bugs.freedesktop.org/show_bug.cgi?id=98245#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - GLES3.1 link negative dEQP "expected linking to fail, but passed."" href="https://bugs.freedesktop.org/show_bug.cgi?id=98245">bug 98245</a> from <a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> Iago Toral</a> <pre>(In reply to Iago Toral from <a href="show_bug.cgi?id=98245#c1">comment #1</a>) > These seem to be two different issues so I think it is probably best to > create two different bug reports. > > I have sent a patch for review that fixes the first one: > <a href="https://lists.freedesktop.org/archives/mesa-dev/2016-October/132896.html">https://lists.freedesktop.org/archives/mesa-dev/2016-October/132896.html</a> This patch is now in master: commit 537dce06ec8e0fa4becd42d5e4b3d07cf722387f Author: Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> Date: Fri Oct 21 13:15:41 2016 +0200 glsl: add matrix layout information to interface block types So far we have been checking that interface block definitions had matching matrix layouts by comparing the definitions of their fields, however, this does not cover the case where the interface blocks are defined with mismatching matrix layouts but don't define any field with a matrix type. In this case Mesa will not fail to link because none of the fields will inherit the mismatching layout qualifier. This patch fixes the problem in the same way we fixed it for packing layout information: we add the the layout information to the interface type and then we check it matches during the uniform block linking process. v2: Fix unit tests so they pass the new parameter to glsl_type::get_interface_instance() Fixes: dEQP-GLES31.functional.shaders.linkage.uniform.block.layout_qualifier_mismatch_3 Bugzilla: <a class="bz_bug_link bz_status_NEW " title="NEW - GLES3.1 link negative dEQP "expected linking to fail, but passed."" href="show_bug.cgi?id=98245">https://bugs.freedesktop.org/show_bug.cgi?id=98245</a> Reviewed-by: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com">nicolai.haehnle@amd.com</a>> (v1)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>