<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Oct 11, 2016 at 12:26 PM, Topi Pohjolainen <span dir="ltr"><<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Blorp operations used to set it before rendering and again just<br> after.<br></blockquote><div><br></div><div>I think this patche is definitely an improvement. 2-5 are<br><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div><div>However, at some point I think we want to revamp our tracking. We really have 3 fast clear states:<br><br></div><div> 1) Resolved (main surface is 100% acurate)<br></div><div> 2) Unresolved (need data from both clear color and CCS)<br></div><div> 3) Partially resolved (only need CCS, clear color doesn't matter)<br><br></div><div>Given the fact that we don't actually use fast clears when CCS is enabled, we never actually hit (2). But... I happen to know you're working on fast clears so I'm sure you'll get to it. :-)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Calling intel_miptree_used_for_<wbr>rendering() for gen6 and earlier<br> as well as for hiz is a no-op. It only deals with color buffers<br> supporting fast clear/lossless compression.<br> <br> Signed-off-by: Topi Pohjolainen <<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a>><br> ---<br> src/mesa/drivers/dri/i965/brw_<wbr>blorp.c | 24 ++++--------------------<br> src/mesa/drivers/dri/i965/brw_<wbr>draw.c | 5 +----<br> src/mesa/drivers/dri/i965/brw_<wbr>wm_surface_state.c | 3 ---<br> src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.h | 6 ++++--<br> 4 files changed, 9 insertions(+), 29 deletions(-)<br></blockquote><div><br></div><div>[snip...]<br></div><div><br></div><div><br></div></div><br></div></div>