<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 28, 2016 at 2:43 PM, Michel Dänzer <span dir="ltr"><<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 28/10/16 06:04 PM, Nayan Deshmukh wrote:<br>
> On Fri, Oct 28, 2016 at 2:14 PM, Michel Dänzer <<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a><br>
</span><span>> <mailto:<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a>>> wrote:<br>
><br>
> On 28/10/16 03:58 PM, Nayan Deshmukh wrote:<br>
> > On Fri, Oct 28, 2016 at 7:00 AM, Michel Dänzer <<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a> <mailto:<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a>><br>
</span><span>> > <mailto:<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a> <mailto:<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a>>>> wrote:<br>
> ><br>
> > On 28/10/16 03:08 AM, Marek Olšák wrote:<br>
> > > On Thu, Oct 27, 2016 at 5:23 PM, Emil Velikov<br>
> <<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a> <mailto:<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.c<wbr>om</a>><br>
</span>> <mailto:<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.<wbr>com</a> <mailto:<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.c<wbr>om</a>>>><br>
> wrote:<br>
> > >> On 17 October 2016 at 10:37, Marek Olšák <<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a> <mailto:<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>> <mailto:<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a><br>
<div><div class="m_-8692428626101925675h5">> <mailto:<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>>>> wrote:<br>
> > >>> Reverting the whole commit is too much. You can just remove the PIPE BIND<br>
> > >>> SHARED usage if you need to.<br>
> > >>><br>
> > >> I'd imagine that one wants to check if radeon(s) behave OK with the<br>
> > >> flag dropped ? Thus it might be better for someone with radeon HW to<br>
> > >> give it a bash.<br>
> > >> Can we have a volunteer please :-)<br>
> > ><br>
> > > r600-radeonsi ignore PIPE_BIND_SHARED on textures.<br>
> ><br>
> > That doesn't mean the state tracker can just drop PIPE_BIND_SHARED.<br>
> ><br>
> > <a href="https://patchwork.freedesktop.org/patch/110569/" rel="noreferrer" target="_blank">https://patchwork.<wbr>freedesktop.org/patch/110569/</a><br>
> <<a href="https://patchwork.freedesktop.org/patch/110569/" rel="noreferrer" target="_blank">https://patchwork.freedeskto<wbr>p.org/patch/110569/</a>><br>
> > <<a href="https://patchwork.freedesktop.org/patch/110569/" rel="noreferrer" target="_blank">https://patchwork.freedeskto<wbr>p.org/patch/110569/</a><br>
> <<a href="https://patchwork.freedesktop.org/patch/110569/" rel="noreferrer" target="_blank">https://patchwork.freedeskto<wbr>p.org/patch/110569/</a>>> seems the best<br>
> > candidate<br>
> > for resolving the nouveau issue, but I suspect as is it might break DRI3<br>
> > PRIME. Nayan, can you check this and fix it up as necessary? Basically,<br>
> > PIPE_BIND_LINEAR is only really necessary for buffers which are sent to<br>
> > the X server for presentation on a different GPU.<br>
> ><br>
> > It works fine with DRI3 Prime with my I+A system, but I think it won't<br>
> > work with a I+N system as it uses PIPE_BIND_SHARE and PIPE_BIND_LINEAR<br>
> > together for one buffer.<br>
><br>
> The patch above removes PIPE_BIND_LINEAR. Which case are you<br>
> thinking of?<br>
><br>
><br>
> We also use PIPE_BIND_LINEAR and PIPE_BIND_SHARED when allocating a<br>
> buffer in vl_winsys_dri3.c, so do we also need to change that?<br>
<br>
</div></div>No, that's for sharing between different GPUs, in which case both flags<br>
are required (even with nouveau).<br>
<div class="m_-8692428626101925675HOEnZb"><div class="m_-8692428626101925675h5"><br></div></div></blockquote><div>Then DRI3 works fine with this change. </div><div><br></div><div>Regards,</div><div>Nayan.</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_-8692428626101925675HOEnZb"><div class="m_-8692428626101925675h5">
<br>
--<br>
Earthling Michel Dänzer | <a href="http://www.amd.com" rel="noreferrer" target="_blank">http://www.amd.com</a><br>
Libre software enthusiast | Mesa and X developer<br>
</div></div></blockquote></div><br></div></div>