<div dir="ltr"><div><div>New patch 19, 20-21, and 25-26 are<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div><div>Patch 24 should be replaced by my two CCS-correct copies patches.  There were issues with 22 and 23 but otherwise things are looking good.<br><br></div><div>--Jason<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 31, 2016 at 1:19 PM, Topi Pohjolainen <span dir="ltr"><<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Ben Widawsky <<a href="mailto:ben@bwidawsk.net">ben@bwidawsk.net</a>><br>
<br>
On SKL (also fast clear is used for level 0, layer 0):<br>
<br>
Manhattan 3.0:          3.88434% +/- 0.814659%<br>
Manhattan 3.0 off:      3.25542% +/- 0.101149%<br>
Trex:                   3.43501% +/- 0.31223%<br>
Trex off:               4.13781% +/- 0.0993569%<br>
<br>
ON BDW:<br>
<br>
Manhattan 3.0:          1.37079% +/- 0.571208%<br>
Manhattan 3.0 off:      1.74029% +/- 0.267499%<br>
<br>
v2 (Ben, Matt): Fix rebase error by removing the perf warning<br>
<br>
Signed-off-by: Ben Widawsky <<a href="mailto:benjamin.widawsky@intel.com">benjamin.widawsky@intel.com</a>><br>
CC: Matt Turner <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>><br>
---<br>
 src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c | 11 +++--------<br>
 1 file changed, 3 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
index ac41fdd..3db18a8 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
@@ -256,16 +256,11 @@ intel_miptree_supports_non_<wbr>msrt_fast_clear(struct brw_context *brw,<br>
<span class="">       if (arrayed)<br>
          assert(mt->num_samples <= 1);<br>
<br>
-      if (mip_mapped && brw->gen >= 8) {<br>
</span>-         perf_debug("Multi-LOD fast clear - giving up (%dx%dx%d).\n",<br>
-                    mt->logical_width0, mt->logical_height0, mt->last_level);<br>
<span class="">+      if (mip_mapped && brw->gen < 8) {<br>
</span><span class="">          return false;<br>
       }<br>
<br>
-      if (arrayed && brw->gen >= 8) {<br>
</span>-         perf_debug("Layered fast clear - giving up. (%dx%d%d)\n",<br>
-                    mt->logical_width0, mt->logical_height0,<br>
-                    mt->physical_depth0);<br>
<span class="">+      if (arrayed && brw->gen < 8) {<br>
</span>          return false;<br>
       }<br>
    }<br>
@@ -1623,7 +1618,7 @@ intel_miptree_alloc_non_msrt_<wbr>mcs(struct brw_context *brw,<br>
<div class="HOEnZb"><div class="h5">       ALIGN(mt->logical_width0, width_divisor) / width_divisor;<br>
    unsigned mcs_height =<br>
       ALIGN(mt->logical_height0, height_divisor) / height_divisor;<br>
-   assert(mt->logical_depth0 == 1);<br>
+   assert(brw->gen >= 8 || mt->logical_depth0 == 1);<br>
    uint32_t layout_flags = MIPTREE_LAYOUT_TILING_Y;<br>
<br>
    if (brw->gen >= 8) {<br>
--<br>
2.5.5<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div>