<div dir="ltr"><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div>Maybe CC stable?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 3, 2016 at 4:35 PM, Eric Anholt <span dir="ltr"><<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We were leaving an undefined value since the ralloc zeroing changes.<br>
Fixes nir_validate() failures on vc4.<br>
---<br>
src/compiler/nir/nir_lower_<wbr>bitmap.c | 1 +<br>
src/compiler/nir/nir_lower_<wbr>drawpixels.c | 1 +<br>
2 files changed, 2 insertions(+)<br>
<br>
diff --git a/src/compiler/nir/nir_lower_<wbr>bitmap.c b/src/compiler/nir/nir_lower_<wbr>bitmap.c<br>
index fefe53cbd814..f08fb9b9c346 100644<br>
--- a/src/compiler/nir/nir_lower_<wbr>bitmap.c<br>
+++ b/src/compiler/nir/nir_lower_<wbr>bitmap.c<br>
@@ -95,6 +95,7 @@ lower_bitmap(nir_shader *shader, nir_builder *b,<br>
tex->sampler_index = options->sampler;<br>
tex->texture_index = options->sampler;<br>
tex->dest_type = nir_type_float;<br>
+ tex->src[0].src_type = nir_tex_src_coord;<br>
tex->src[0].src = nir_src_for_ssa(texcoord);<br>
<br>
nir_ssa_dest_init(&tex->instr, &tex->dest, 4, 32, NULL);<br>
diff --git a/src/compiler/nir/nir_lower_<wbr>drawpixels.c b/src/compiler/nir/nir_lower_<wbr>drawpixels.c<br>
index 54f3ea08aadb..417e27fc1772 100644<br>
--- a/src/compiler/nir/nir_lower_<wbr>drawpixels.c<br>
+++ b/src/compiler/nir/nir_lower_<wbr>drawpixels.c<br>
@@ -134,6 +134,7 @@ lower_color(lower_drawpixels_<wbr>state *state, nir_intrinsic_instr *intr)<br>
tex->sampler_index = state->options->drawpix_<wbr>sampler;<br>
tex->texture_index = state->options->drawpix_<wbr>sampler;<br>
tex->dest_type = nir_type_float;<br>
+ tex->src[0].src_type = nir_tex_src_coord;<br>
tex->src[0].src = nir_src_for_ssa(texcoord);<br>
<br>
nir_ssa_dest_init(&tex->instr, &tex->dest, 4, 32, NULL);<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.10.1<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>