<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
I’d prefer parenthesis to clarify the logic "(foo && ((bar == bla) || footer)”.
<div class=""><br class="">
</div>
<div class="">With those added, Reviewed-by: Tim Rowley <<a href="mailto:timothy.o.rowley@intel.com" class="">timothy.o.rowley@intel.com</a>></div>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Nov 8, 2016, at 4:30 PM, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" class="">imirkin@alum.mit.edu</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" class="">imirkin@alum.mit.edu</a>><br class="">
---<br class="">
src/gallium/drivers/swr/swr_state.cpp | 6 ++++++<br class="">
1 file changed, 6 insertions(+)<br class="">
<br class="">
diff --git a/src/gallium/drivers/swr/swr_state.cpp b/src/gallium/drivers/swr/swr_state.cpp<br class="">
index d8a8ee1..d16c307 100644<br class="">
--- a/src/gallium/drivers/swr/swr_state.cpp<br class="">
+++ b/src/gallium/drivers/swr/swr_state.cpp<br class="">
@@ -1305,6 +1305,12 @@ swr_update_derived(struct pipe_context *pipe,<br class="">
&ctx->blend->compileState[target],<br class="">
sizeof(compileState.blendState));<br class="">
<br class="">
+ const SWR_FORMAT_INFO& info = GetFormatInfo(compileState.format);<br class="">
+ if (compileState.blendState.logicOpEnable &&<br class="">
+ (info.type[0] == SWR_TYPE_FLOAT || info.isSRGB)) {<br class="">
+ compileState.blendState.logicOpEnable = false;<br class="">
+ }<br class="">
+<br class="">
if (compileState.blendState.blendEnable == false &&<br class="">
compileState.blendState.logicOpEnable == false) {<br class="">
SwrSetBlendFunc(ctx->swrContext, target, NULL);<br class="">
-- <br class="">
2.7.3<br class="">
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>