<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Reviewed-by: Tim Rowley <<a href="mailto:timothy.o.rowley@intel.com" class="">timothy.o.rowley@intel.com</a>>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Nov 8, 2016, at 11:03 PM, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" class="">imirkin@alum.mit.edu</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" class="">imirkin@alum.mit.edu</a>><br class="">
---<br class="">
<br class="">
This improves bin/arb_clip_control-clip-control results, but still not<br class="">
quite there yet.<br class="">
<br class="">
src/gallium/drivers/swr/swr_state.cpp | 10 +++-------<br class="">
1 file changed, 3 insertions(+), 7 deletions(-)<br class="">
<br class="">
diff --git a/src/gallium/drivers/swr/swr_state.cpp b/src/gallium/drivers/swr/swr_state.cpp<br class="">
index ede475a..01cadce 100644<br class="">
--- a/src/gallium/drivers/swr/swr_state.cpp<br class="">
+++ b/src/gallium/drivers/swr/swr_state.cpp<br class="">
@@ -38,6 +38,7 @@<br class="">
#include "util/u_inlines.h"<br class="">
#include "util/u_helpers.h"<br class="">
#include "util/u_framebuffer.h"<br class="">
+#include "util/u_viewport.h"<br class="">
<br class="">
#include "swr_state.h"<br class="">
#include "swr_context.h"<br class="">
@@ -951,13 +952,8 @@ swr_update_derived(struct pipe_context *pipe,<br class="">
vp->width = state->translate[0] + state->scale[0];<br class="">
vp->y = state->translate[1] - fabs(state->scale[1]);<br class="">
vp->height = state->translate[1] + fabs(state->scale[1]);<br class="">
- if (rasterizer->clip_halfz == 0) {<br class="">
- vp->minZ = state->translate[2] - state->scale[2];<br class="">
- vp->maxZ = state->translate[2] + state->scale[2];<br class="">
- } else {<br class="">
- vp->minZ = state->translate[2];<br class="">
- vp->maxZ = state->translate[2] + state->scale[2];<br class="">
- }<br class="">
+ util_viewport_zmin_zmax(state, rasterizer->clip_halfz,<br class="">
+ &vp->minZ, &vp->maxZ);<br class="">
<br class="">
vpm->m00[0] = state->scale[0];<br class="">
vpm->m11[0] = state->scale[1];<br class="">
-- <br class="">
2.7.3<br class="">
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>