<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64'"
href="https://bugs.freedesktop.org/show_bug.cgi?id=98681#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64'"
href="https://bugs.freedesktop.org/show_bug.cgi?id=98681">bug 98681</a>
from <span class="vcard"><a class="email" href="mailto:brianp@vmware.com" title="Brian Paul <brianp@vmware.com>"> <span class="fn">Brian Paul</span></a>
</span></b>
<pre>(In reply to Roland Scheidegger from <a href="show_bug.cgi?id=98681#c4">comment #4</a>)
<span class="quote">> (In reply to Brian Paul from <a href="show_bug.cgi?id=98681#c3">comment #3</a>)
> > Actually, this is still failing with our Jenkins build. Hmm...
>
> I've got some feeling this is due this being in c++ code?</span >
Yes. It looks like this is the first place we've compiled a .cpp file with
PRIx64 with MinGW.
My local MinGW build is picking up inttypes.h from /usr/include/inttypes.h but
on Jenkins it's picking /usr/i686-w64-mingw32/include/inttypes.h. Don't know
why. In the later, the PRI* macros are not defined for __cplusplus.
It looks like we have to add something like
#ifndef PRIx64
#define PRIx64 "lx"
#endif
in ir_builder_print_visitor.cpp
But then I get additional warnings about the format string and argument type
not agreeing. And defining PRIx64 to "llx" yields other warnings in my test:
pri64.cpp:17:42: warning: unknown conversion type character ‘l’ in format
[-Wformat]
pri64.cpp:17:42: warning: too many arguments for format [-Wformat-extra-args]
I think I'll just have to add the #ifndef stuff and live with the warning.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>