<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Sat, Nov 12, 2016 at 1:35 PM Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This series started off as me thinking that we should set the correct<br class="gmail_msg">
sampler and binding table entry counts because maybe caching those things<br class="gmail_msg">
would improve performance. Then it turned into spring cleaning. The end<br class="gmail_msg">
result is that gen7_pipeline.c, gen8_pipeline.c, and genX_pipeline_util.h<br class="gmail_msg">
are all merged into genX_pipeline.c. Every single packet in pipeline setup<br class="gmail_msg">
now has a common path.<br class="gmail_msg"></blockquote><div><br></div><div>This looks great, thanks for finally unifying things the way we always meant to and getting rid of genX_pipeline_util.h.</div><div><br></div><div>For the series:</div><div><br></div><div>Reviewed-by: Kristian H. Kristensen <<a href="mailto:hoegsberg@google.com">hoegsberg@google.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I still haven't tested the performance of cached sampler states.<br class="gmail_msg"></blockquote><div><br></div><div>I'd be interested to hear if you're able to measure anything one way or the other.</div><div><br></div><div>Kristian</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
Jason Ekstrand (20):<br class="gmail_msg">
anv/pipeline: Set correct binding table and sampler counts<br class="gmail_msg">
anv/pipeline: Get rid of the kernel pointer fields<br class="gmail_msg">
intel/genxml: Make some VS/GS fields consistent across gens<br class="gmail_msg">
anv/pipeline: Stop claiming to support running without a vertex shader<br class="gmail_msg">
anv/pipeline/gen8: Enable VS statistics<br class="gmail_msg">
anv/pipeline: Unify 3DSTATE_VS emission<br class="gmail_msg">
intel/genxml: Make some 3DSTATE_GS fields more consistent<br class="gmail_msg">
anv/pipeline: Unify 3DSTATE_GS emission<br class="gmail_msg">
anv/pipeline: Make emit_3dstate_sbe safe to call without a FS<br class="gmail_msg">
intel/genxml: Make some 3DSTATE_PS fields more consistent<br class="gmail_msg">
anv/pipeline: Unify 3DSTATE_PS emission<br class="gmail_msg">
intel/genxml: Make 3DSTATE_WM more consistent across gens<br class="gmail_msg">
anv/pipeline: Unify 3DSTATE_WM emission<br class="gmail_msg">
anv/pipeline: Move 3DSTATE_PS_EXTRA setup into a helper<br class="gmail_msg">
anv/pipeline: Rework the 3DSTATE_VF_TOPOLOGY helper<br class="gmail_msg">
anv/pipline: Re-order state emission and make it consistent<br class="gmail_msg">
anv/pipeline: Unify graphics_pipeline_create<br class="gmail_msg">
anv/pipeline: Roll genX_pipeline_util.h into genX_pipeline.c<br class="gmail_msg">
anv: Move INTERFACE_DESCRIPTOR_DATA setup to the pipeline<br class="gmail_msg">
anv/pipeline: Use get_scratch_space/address for compute shaders<br class="gmail_msg">
<br class="gmail_msg">
src/intel/blorp/blorp_genX_exec.h | 12 +-<br class="gmail_msg">
src/intel/genxml/gen6.xml | 32 +-<br class="gmail_msg">
src/intel/genxml/gen7.xml | 32 +-<br class="gmail_msg">
src/intel/genxml/gen75.xml | 32 +-<br class="gmail_msg">
src/intel/genxml/gen8.xml | 8 +-<br class="gmail_msg">
src/intel/genxml/gen9.xml | 8 +-<br class="gmail_msg">
src/intel/vulkan/Makefile.sources | 5 -<br class="gmail_msg">
src/intel/vulkan/anv_genX.h | 7 -<br class="gmail_msg">
src/intel/vulkan/anv_pipeline.c | 22 -<br class="gmail_msg">
src/intel/vulkan/anv_private.h | 7 +-<br class="gmail_msg">
src/intel/vulkan/gen7_pipeline.c | 281 -------<br class="gmail_msg">
src/intel/vulkan/gen8_pipeline.c | 295 -------<br class="gmail_msg">
src/intel/vulkan/genX_cmd_buffer.c | 35 +-<br class="gmail_msg">
src/intel/vulkan/genX_pipeline.c | 1393 ++++++++++++++++++++++++++++++++-<br class="gmail_msg">
src/intel/vulkan/genX_pipeline_util.h | 959 -----------------------<br class="gmail_msg">
15 files changed, 1471 insertions(+), 1657 deletions(-)<br class="gmail_msg">
delete mode 100644 src/intel/vulkan/gen7_pipeline.c<br class="gmail_msg">
delete mode 100644 src/intel/vulkan/gen8_pipeline.c<br class="gmail_msg">
delete mode 100644 src/intel/vulkan/genX_pipeline_util.h<br class="gmail_msg">
<br class="gmail_msg">
--<br class="gmail_msg">
2.5.0.400.gff86faf<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
mesa-dev mailing list<br class="gmail_msg">
<a href="mailto:mesa-dev@lists.freedesktop.org" class="gmail_msg" target="_blank">mesa-dev@lists.freedesktop.org</a><br class="gmail_msg">
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br class="gmail_msg">
</blockquote></div></div>