<div dir="ltr">Also, please Cc stable<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 14, 2016 at 9:29 AM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5">On Mon, Nov 14, 2016 at 5:23 AM, Iago Toral Quiroga <span dir="ltr"><<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">According to the spec for vkGetPhysicalDeviceImageFormat<wbr>Properties:<br>
<br>
"If format is not a supported image format, or if the combination of format,<br>
type, tiling, usage, and flags is not supported for images, then<br>
<wbr>vkGetPhysicalDeviceImageFormat<wbr>Properties returns VK_ERROR_FORMAT_NOT_SUPPORTED.<wbr>"<br>
<br>
Makes the following Vulkan CTS tests report 'Not Supported' instead of crashing:<br>
<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8_unorm<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8_snorm<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8_uscal<wbr>ed<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8_sscal<wbr>ed<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8_uint<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8_sint<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8_srgb<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8a8_uno<wbr>rm<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8a8_sno<wbr>rm<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8a8_usc<wbr>aled<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8a8_ssc<wbr>aled<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8a8_uin<wbr>t<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8a8_sin<wbr>t<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b8g8r8a8_srg<wbr>b<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_r4g4_unorm_<wbr>pack8<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_r8_srgb<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_r8g8_srgb<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_r8g8b8_srgb<br>
dEQP-VK.api.image_clearing.cle<wbr>ar_color_image.1d_b5g5r5a1_uno<wbr>rm_pack16<br>
---<br>
src/intel/vulkan/anv_formats.<wbr>c | 3 +++<br>
1 file changed, 3 insertions(+)<br>
<br>
diff --git a/src/intel/vulkan/anv_formats<wbr>.c b/src/intel/vulkan/anv_formats<wbr>.c<br>
index 7497a38..bca9aeb 100644<br>
--- a/src/intel/vulkan/anv_formats<wbr>.c<br>
+++ b/src/intel/vulkan/anv_formats<wbr>.c<br>
@@ -511,6 +511,9 @@ VkResult anv_GetPhysicalDeviceImageForm<wbr>atProperties(<br>
break;<br>
}<br>
<br>
+ if (anv_formats[format].isl_forma<wbr>t == ISL_FORMAT_UNSUPPORTED)<br>
+ goto unsupported;<br>
+<br></blockquote><div><br></div></div></div><div>Can we move this a bit higher up? This is an early return so it makes sense to return as quickly as we can.<br><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>><br></div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
/* Our hardware doesn't support 1D compressed textures.<br>
* From the SKL PRM, RENDER_SURFACE_STATE::SurfaceF<wbr>ormat:<br>
* * This field cannot be a compressed (BC*, DXT*, FXT*, ETC*, EAC*) format<br>
<span class="m_933473694553935287HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></span></div><br></div></div>
</blockquote></div><br></div>