<p dir="ltr">Of you want to make it simpler, we have a macro wrapper called isl_surf_init that will turn those fields into named parameters. Either way, thanks for fixing this up. Rb</p>
<div class="gmail_extra"><br><div class="gmail_quote">On Nov 15, 2016 11:23 AM, "Jordan Justen" <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Jordan Justen <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>><br>
---<br>
src/intel/blorp/blorp_blit.c | 29 +++++++++++++----------------<br>
1 file changed, 13 insertions(+), 16 deletions(-)<br>
<br>
diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c<br>
index 1108335..c0b56c3 100644<br>
--- a/src/intel/blorp/blorp_blit.c<br>
+++ b/src/intel/blorp/blorp_blit.c<br>
@@ -1347,22 +1347,19 @@ surf_convert_to_single_slice(<wbr>const struct isl_device *isl_dev,<br>
uint32_t tile_x_px, tile_y_px;<br>
surf_get_intratile_offset_px(<wbr>info, &tile_x_px, &tile_y_px);<br>
<br>
- /* TODO: Once this file gets converted to C, we shouls just use designated<br>
- * initializers.<br>
- */<br>
- struct isl_surf_init_info init_info = { 0, };<br>
-<br>
- init_info.dim = ISL_SURF_DIM_2D;<br>
- init_info.format = info->surf.format;<br>
- init_info.width = slice_width_px + tile_x_px;<br>
- init_info.height = slice_height_px + tile_y_px;<br>
- init_info.depth = 1;<br>
- init_info.levels = 1;<br>
- init_info.array_len = 1;<br>
- init_info.samples = info->surf.samples;<br>
- init_info.min_pitch = info->surf.row_pitch;<br>
- init_info.usage = info->surf.usage;<br>
- init_info.tiling_flags = 1 << info->surf.tiling;<br>
+ struct isl_surf_init_info init_info = {<br>
+ .dim = ISL_SURF_DIM_2D,<br>
+ .format = info->surf.format,<br>
+ .width = slice_width_px + tile_x_px,<br>
+ .height = slice_height_px + tile_y_px,<br>
+ .depth = 1,<br>
+ .levels = 1,<br>
+ .array_len = 1,<br>
+ .samples = info->surf.samples,<br>
+ .min_pitch = info->surf.row_pitch,<br>
+ .usage = info->surf.usage,<br>
+ .tiling_flags = 1 << info->surf.tiling,<br>
+ };<br>
<br>
isl_surf_init_s(isl_dev, &info->surf, &init_info);<br>
assert(info->surf.row_pitch == init_info.min_pitch);<br>
<font color="#888888">--<br>
2.10.2<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></blockquote></div><br></div>