<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Reviewed-by: Tim Rowley <<a href="mailto:timothy.o.rowley@intel.com" class="">timothy.o.rowley@intel.com</a>>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Nov 17, 2016, at 6:51 PM, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" class="">imirkin@alum.mit.edu</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">The non-fast-clear path was never updated after clear colors were passed<br class="">
in as floats. Remove the now-harmful conversion from unorm8.<br class="">
<br class="">
Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" class="">imirkin@alum.mit.edu</a>><br class="">
---<br class="">
src/gallium/drivers/swr/rasterizer/core/backend.cpp | 14 ++++----------<br class="">
1 file changed, 4 insertions(+), 10 deletions(-)<br class="">
<br class="">
diff --git a/src/gallium/drivers/swr/rasterizer/core/backend.cpp b/src/gallium/drivers/swr/rasterizer/core/backend.cpp<br class="">
index 37de650..45eff15 100644<br class="">
--- a/src/gallium/drivers/swr/rasterizer/core/backend.cpp<br class="">
+++ b/src/gallium/drivers/swr/rasterizer/core/backend.cpp<br class="">
@@ -285,17 +285,11 @@ void ProcessClearBE(DRAW_CONTEXT *pDC, uint32_t workerId, uint32_t macroTile, vo<br class="">
<br class="">
if (pClear->attachmentMask & SWR_ATTACHMENT_MASK_COLOR)<br class="">
{<br class="">
- /// @todo clear data should come in as RGBA32_FLOAT<br class="">
DWORD clearData[4];<br class="">
- float clearFloat[4];<br class="">
- clearFloat[0] = ((uint8_t*)(&pClear->clearRTColor))[0] / 255.0f;<br class="">
- clearFloat[1] = ((uint8_t*)(&pClear->clearRTColor))[1] / 255.0f;<br class="">
- clearFloat[2] = ((uint8_t*)(&pClear->clearRTColor))[2] / 255.0f;<br class="">
- clearFloat[3] = ((uint8_t*)(&pClear->clearRTColor))[3] / 255.0f;<br class="">
- clearData[0] = *(DWORD*)&clearFloat[0];<br class="">
- clearData[1] = *(DWORD*)&clearFloat[1];<br class="">
- clearData[2] = *(DWORD*)&clearFloat[2];<br class="">
- clearData[3] = *(DWORD*)&clearFloat[3];<br class="">
+ clearData[0] = *(DWORD*)&(pClear->clearRTColor[0]);<br class="">
+ clearData[1] = *(DWORD*)&(pClear->clearRTColor[1]);<br class="">
+ clearData[2] = *(DWORD*)&(pClear->clearRTColor[2]);<br class="">
+ clearData[3] = *(DWORD*)&(pClear->clearRTColor[3]);<br class="">
<br class="">
PFN_CLEAR_TILES pfnClearTiles = sClearTilesTable[KNOB_COLOR_HOT_TILE_FORMAT];<br class="">
SWR_ASSERT(pfnClearTiles != nullptr);<br class="">
-- <br class="">
2.7.3<br class="">
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>