<div dir="ltr">The HW limits here are -8/7 when using the gather4 message. [gather4_po allows -32/31, and specified per channel]</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 28, 2016 at 10:49 AM, Ilia Mirkin <span dir="ltr"><<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This matches what NVIDIA and AMD hardware expose.<br>
<br>
Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>><br>
---<br>
<br>
Not sure what the true HW limit is here. On NVIDIA, the true HW limit really<br>
is -32/31 though. As an aside, according to <a href="http://vulkan.gpuinfo.org" rel="noreferrer" target="_blank">vulkan.gpuinfo.org</a>, the Intel<br>
Windows driver also exposes -32/31.<br>
<br>
With the updated limits on SKL, everything still passes:<br>
<br>
./deqp-vk --deqp-visibility=hidden --deqp-case='*texture_gather*'<br>
Test run totals:<br>
Passed: 762/1524 (50.0%)<br>
Failed: 0/1524 (0.0%)<br>
Not supported: 762/1524 (50.0%)<br>
Warnings: 0/1524 (0.0%)<br>
<br>
src/intel/vulkan/anv_device.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_device.<wbr>c b/src/intel/vulkan/anv_device.<wbr>c<br>
index 16aba59..d20dc0f 100644<br>
--- a/src/intel/vulkan/anv_device.<wbr>c<br>
+++ b/src/intel/vulkan/anv_device.<wbr>c<br>
@@ -555,8 +555,8 @@ void anv_<wbr>GetPhysicalDeviceProperties(<br>
.<wbr>minStorageBufferOffsetAlignmen<wbr>t = 1,<br>
.minTexelOffset = -8,<br>
.maxTexelOffset = 7,<br>
- .minTexelGatherOffset = -8,<br>
- .maxTexelGatherOffset = 7,<br>
+ .minTexelGatherOffset = -32,<br>
+ .maxTexelGatherOffset = 31,<br>
.minInterpolationOffset = -0.5,<br>
.maxInterpolationOffset = 0.4375,<br>
.<wbr>subPixelInterpolationOffsetBit<wbr>s = 4,<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>