<div dir="ltr"><div>Seems reasonable,<br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 28, 2016 at 7:25 PM, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
<br>
Noticed while adding support for 64-bit integer types.<br>
<br>
Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
Reviewed-by: Connor Abbott <<a href="mailto:cwabbott0@gmail.com">cwabbott0@gmail.com</a>><br>
Cc: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>><br>
---<br>
src/compiler/nir/nir_split_<wbr>var_copies.c | 8 +++++---<br>
1 file changed, 5 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/compiler/nir/nir_split_<wbr>var_copies.c b/src/compiler/nir/nir_split_<wbr>var_copies.c<br>
index f9ad49a..63a7611 100644<br>
--- a/src/compiler/nir/nir_split_<wbr>var_copies.c<br>
+++ b/src/compiler/nir/nir_split_<wbr>var_copies.c<br>
@@ -231,9 +231,6 @@ split_var_copies_block(nir_<wbr>block *block, struct split_var_copies_state *state)<br>
break;<br>
case GLSL_TYPE_FLOAT:<br>
case GLSL_TYPE_DOUBLE:<br>
- case GLSL_TYPE_INT:<br>
- case GLSL_TYPE_UINT:<br>
- case GLSL_TYPE_BOOL:<br>
if (glsl_type_is_matrix(src_tail-<wbr>>type)) {<br>
split_var_copy_instr(<wbr>intrinsic, dest_head, src_head,<br>
dest_tail, src_tail, state);<br>
@@ -241,6 +238,11 @@ split_var_copies_block(nir_<wbr>block *block, struct split_var_copies_state *state)<br>
ralloc_steal(state->dead_ctx, instr);<br>
}<br>
break;<br>
+ case GLSL_TYPE_INT:<br>
+ case GLSL_TYPE_UINT:<br>
+ case GLSL_TYPE_BOOL:<br>
+ assert(!glsl_type_is_matrix(<wbr>src_tail->type));<br>
+ break;<br>
default:<br>
unreachable("Invalid type");<br>
break;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div></div></div>