<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Nov 30, 2016 at 10:20 AM, Nanley Chery <span dir="ltr"><<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Nov 29, 2016 at 05:41:58PM -0800, Jason Ekstrand wrote:<br>
> In an attempt to fix 3DSTATE_DEPTH_BUFFER for stencil-only cases, I<br>
> accidentally kept setting the SurfaceType to 2D in the stencil-only case<br>
> thanks to a copy+paste error.<br>
><br>
> Cc: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br>
> ---<br>
>  src/intel/vulkan/genX_cmd_<wbr>buffer.c | 2 +-<br>
>  1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
</span>Thanks for the fix! This patch is,<br>
Reviewed-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><span class="im HOEnZb"><br></span></blockquote><div><br></div><div>Thanks!  Pushed.  Sorry for the mess.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="im HOEnZb">
><br>
> diff --git a/src/intel/vulkan/genX_cmd_<wbr>buffer.c b/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
> index 73f4523..f761d9a 100644<br>
> --- a/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
> +++ b/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
> @@ -2153,7 +2153,7 @@ cmd_buffer_emit_depth_stencil(<wbr>struct anv_cmd_buffer *cmd_buffer)<br>
>         */<br>
>        anv_batch_emit(&cmd_buffer-><wbr>batch, GENX(3DSTATE_DEPTH_BUFFER), db) {<br>
>           if (has_stencil) {<br>
> -            db.SurfaceType       = SURFTYPE_2D;<br>
> +            db.SurfaceType       =<br>
>                 depth_stencil_surface_type(<wbr>image->stencil_surface.isl.<wbr>dim);<br>
>           } else {<br>
>              db.SurfaceType       = SURFTYPE_2D;<br>
> --<br>
> 2.5.0.400.gff86faf<br>
><br>
</span><div class="HOEnZb"><div class="h5">> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>