<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Not seeing this assert fire on our tests either.
<div class=""><br class="">
</div>
<div class="">Reviewed-by: Tim Rowley <<a href="mailto:timothy.o.rowley@intel.com" class="">timothy.o.rowley@intel.com</a>>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Nov 29, 2016, at 8:04 PM, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" class="">imirkin@alum.mit.edu</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" class="">imirkin@alum.mit.edu</a>><br class="">
---<br class="">
<br class="">
I've been running this for a little while and haven't hit it. I had a theory<br class="">
at one point that there was a missing format in there which turned out to be<br class="">
false, but I think this is still good to have rather than silently fail.<br class="">
<br class="">
src/gallium/drivers/swr/rasterizer/memory/Convert.h | 1 +<br class="">
1 file changed, 1 insertion(+)<br class="">
<br class="">
diff --git a/src/gallium/drivers/swr/rasterizer/memory/Convert.h b/src/gallium/drivers/swr/rasterizer/memory/Convert.h<br class="">
index c31459c..527324c 100644<br class="">
--- a/src/gallium/drivers/swr/rasterizer/memory/Convert.h<br class="">
+++ b/src/gallium/drivers/swr/rasterizer/memory/Convert.h<br class="">
@@ -724,6 +724,7 @@ INLINE static void ConvertPixelFromFloat(<br class="">
case R8G8B8_SINT: ConvertPixelFromFloat<R8G8B8_SINT>(pDst, srcPixel); break;<br class="">
case RAW: ConvertPixelFromFloat<RAW>(pDst, srcPixel); break;<br class="">
default:<br class="">
+ SWR_ASSERT(0);<br class="">
break;<br class="">
}<br class="">
}<br class="">
-- <br class="">
2.7.3<br class="">
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</body>
</html>