<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Reviewed-by: Tim Rowley <<a href="mailto:timothy.o.rowley@intel.com" class="">timothy.o.rowley@intel.com</a>>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Nov 16, 2016, at 9:04 PM, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" class="">imirkin@alum.mit.edu</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Since we don't pass a renderTargetArrayIndex in, and the current hot<br class="">
tile may be for a different index, we may end up loading the RTAI=0 into<br class="">
the hot tile for no reason.<br class="">
<br class="">
Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" class="">imirkin@alum.mit.edu</a>><br class="">
---<br class="">
<br class="">
Noticed this when doing an audit of GetHotTile calls without a renderTargetArrayIndex being passed in. In this case, I don't think it should be loading at all...<br class="">
<br class="">
Note that this has not been rigorously tested.<br class="">
<br class="">
src/gallium/drivers/swr/rasterizer/core/backend.cpp | 2 +-<br class="">
1 file changed, 1 insertion(+), 1 deletion(-)<br class="">
<br class="">
diff --git a/src/gallium/drivers/swr/rasterizer/core/backend.cpp b/src/gallium/drivers/swr/rasterizer/core/backend.cpp<br class="">
index 3375585..29d0ff5 100644<br class="">
--- a/src/gallium/drivers/swr/rasterizer/core/backend.cpp<br class="">
+++ b/src/gallium/drivers/swr/rasterizer/core/backend.cpp<br class="">
@@ -361,7 +361,7 @@ void ProcessStoreTileBE(DRAW_CONTEXT *pDC, uint32_t workerId, uint32_t macroTile<br class="">
MacroTileMgr::getTileIndices(macroTile, x, y);<br class="">
<br class="">
// Only need to store the hottile if it's been rendered to...<br class="">
- HOTTILE *pHotTile = pContext->pHotTileMgr->GetHotTile(pContext, pDC, macroTile, attachment, false);<br class="">
+ HOTTILE *pHotTile = pContext->pHotTileMgr->GetHotTileNoLoad(pContext, pDC, macroTile, attachment, false);<br class="">
if (pHotTile)<br class="">
{<br class="">
// clear if clear is pending (i.e., not rendered to), then mark as dirty for store.<br class="">
-- <br class="">
2.7.3<br class="">
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>