<div dir="ltr">Thanks! I'll keep 15 and 17 out. I'd still like to have tile mode as an enum, but maybe I'll make the generator split inline values out as enums - or maybe just when you've specified an enum name as the type. That is,<div><br></div><div> <field name="Tile Mode" start="12" end="13" type="TILE_MODE"><div> <value name="LINEAR" value="0"/></div><div> <value name="WMAJOR" value="1"/></div><div> <value name="XMAJOR" value="2"/></div><div> <value name="YMAJOR" value="3"/></div><div> </field></div><div><br></div><div>generates</div><div><br></div><div>enum GEN9_TILE_MODE {</div><div> LINEAR = 0,</div><div> WMAJOR = 1,</div><div> XMAJOR = 2,</div><div> YMAJOR = 3,</div><div>};</div><div><br></div><div>and</div><div><br></div><div>struct GEN9_SURFACE_STATE {</div><div> ...</div><div> enum GEN9_TILE_MODE TileMode;</div><div> ...</div><div>};</div><div><br></div><div>Kristian</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 29, 2016 at 4:19 PM Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg">I'm a bit inclined to drop patch 15 because I think tile mode deserves to remain inline. I don't care about 17. I didn't really review it for not breaking things though. The rest are<br class="gmail_msg"><br class="gmail_msg"></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" class="gmail_msg" target="_blank">jason@jlekstrand.net</a>><br class="gmail_msg"><br class="gmail_msg"></div>Don't push until you get Jenkins' ok though!<br class="gmail_msg"><br class="gmail_msg"></div>--Jason<br class="gmail_msg"></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"></div></div><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg">On Tue, Nov 29, 2016 at 12:55 PM, Kristian Høgsberg <span dir="ltr" class="gmail_msg"><<a href="mailto:hoegsberg@gmail.com" class="gmail_msg" target="_blank">hoegsberg@gmail.com</a>></span> wrote:<br class="gmail_msg"></div></div><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_quote gmail_msg"><span class="gmail_msg"><div dir="ltr" class="gmail_msg">On Tue, Nov 29, 2016 at 12:48 PM Kristian H. Kristensen <<a href="mailto:hoegsberg@gmail.com" class="gmail_msg" target="_blank">hoegsberg@gmail.com</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> <br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> Here's a few patches to the genxml files that I've been sitting on. The<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> main part of the series is about emitting C enums for genxml enums, so<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> it looks nice and pretty in gdb. It also adds support to aubinator so<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> it knows how to decode enums as well as the inline values Lionel added<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> support for:<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> <br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> Surface Array: true<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> Surface Format: 2 (R32G32B32A32_UINT)<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> Surface Vertical Alignment: 1 (VALIGN 4)<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> <br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> Look at that surface format being decoded! Patch 17 is "take it or<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> leave it". I know nothing in mesa needs unpack functions, but I wouldn't<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"> mind having it upstream so I don't lose it (again).<br class="m_7327592181770003673m_-1602583395830110036gmail_msg gmail_msg"></blockquote><div class="gmail_msg"><br class="gmail_msg"></div></span><div class="gmail_msg">Oh, and true to form, I forgot the most important point: patch 16 is a legitimate</div><div class="gmail_msg">fix for the compute shader KSP being split across a innocuous looking KernelStartPointer</div><div class="gmail_msg">32 bit field and a 16 bit "Kernel Start Pointer High" field. The driver doesn't know this</div><div class="gmail_msg">and only sets KernelStartPointer. As long as anv uses instruction base offset, it's unlikely to</div><div class="gmail_msg">cause a problem, but should be fixed.</div><span class="m_7327592181770003673HOEnZb gmail_msg"><font color="#888888" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Kristian</div></font></span></div></div> <br class="gmail_msg"></blockquote></div></div><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">_______________________________________________<br class="gmail_msg"> mesa-dev mailing list<br class="gmail_msg"> <a href="mailto:mesa-dev@lists.freedesktop.org" class="gmail_msg" target="_blank">mesa-dev@lists.freedesktop.org</a><br class="gmail_msg"> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br class="gmail_msg"> <br class="gmail_msg"></blockquote></div><br class="gmail_msg"></div> </blockquote></div></div></div>