<html><head></head><body><div>On Thu, 2016-12-01 at 18:58 -0800, Jason Ekstrand wrote:</div><blockquote type="cite"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 25, 2016 at 12:52 AM, Juan A. Suarez Romero <span dir="ltr"><<a href="mailto:jasuarez@igalia.com" target="_blank">jasuarez@igalia.com</a>></span> wrote:<br><blockquote type="cite">From: Samuel Iglesias Gonsálvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>><br>
<br>
We use *64*_PASSTHRU formats to upload vertex attributes of 64 bits<br>
to avoid conversions. From the BDW PRM, Volume 2d, page 586<br>
(VERTEX_ELEMENT_STATE):<br>
<br>
"When SourceElementFormat is set to one of the *64*_PASSTHRU<br>
formats, 64-bit components are stored in the URB without any<br>
conversion. In this case, vertex elements must be written as 128<br>
or 256 bits, with VFCOMP_STORE_0 being used to pad the output<br>
as required. E.g., if R64_PASSTHRU is used to copy a 64-bit Red<br>
component into the URB, Component 1 must be specified as<br>
VFCOMP_STORE_0 (with Components 2,3 set to VFCOMP_NOSTORE)<br>
in order to output a 128-bit vertex element, or Components 1-3 must<br>
be specified as VFCOMP_STORE_0 in order to output a 256-bit vertex<br>
element. Likewise, use of R64G64B64_PASSTHRU requires Component 3<br>
to be specified as VFCOMP_STORE_0 in order to output a 256-bit vertex<br>
element."<br>
<br>
Signed-off-by: Samuel Iglesias Gonsálvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>><br>
---<br>
src/intel/isl/isl_format.c | 4 ++--<br>
src/intel/isl/isl_format_<wbr>layout.csv | 3 ---<br>
src/intel/vulkan/anv_formats.c | 8 ++++----<br>
3 files changed, 6 insertions(+), 9 deletions(-)<br>
<br>
diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c<br>
index 98806f4..92b630a 100644<br>
--- a/src/intel/isl/isl_format.c<br>
+++ b/src/intel/isl/isl_format.c<br>
@@ -97,7 +97,7 @@ static const struct surface_format_info format_info[] = {<br>
SF( x, x, x, x, x, x, Y, x, x, x, R32G32B32A32_SSCALED)<br>
SF( x, x, x, x, x, x, Y, x, x, x, R32G32B32A32_USCALED)<br>
SF( x, x, x, x, x, x, 75, x, x, x, R32G32B32A32_SFIXED)<br>
- SF( x, x, x, x, x, x, x, x, x, x, R64G64_PASSTHRU)<br>
+ SF( x, x, x, x, x, x, 80, x, x, x, R64G64_PASSTHRU)<br>
SF( Y, 50, x, x, x, x, Y, Y, x, x, R32G32B32_FLOAT)<br>
SF( Y, x, x, x, x, x, Y, Y, x, x, R32G32B32_SINT)<br>
SF( Y, x, x, x, x, x, Y, Y, x, x, R32G32B32_UINT)<br>
@@ -131,7 +131,7 @@ static const struct surface_format_info format_info[] = {<br>
SF( x, x, x, x, x, x, Y, x, x, x, R32G32_SSCALED)<br>
SF( x, x, x, x, x, x, Y, x, x, x, R32G32_USCALED)<br>
SF( x, x, x, x, x, x, 75, x, x, x, R32G32_SFIXED)<br>
- SF( x, x, x, x, x, x, x, x, x, x, R64_PASSTHRU)<br>
+ SF( x, x, x, x, x, x, 80, x, x, x, R64_PASSTHRU)<br>
SF( Y, Y, x, Y, Y, Y, Y, x, 60, 90, B8G8R8A8_UNORM)<br>
SF( Y, Y, x, x, Y, Y, x, x, x, x, B8G8R8A8_UNORM_SRGB)<br>
/* smpl filt shad CK RT AB VB SO color ccs_e */<br>
diff --git a/src/intel/isl/isl_format_<wbr>layout.csv b/src/intel/isl/isl_format_<wbr>layout.csv<br>
index f0f31c7..b1e298b 100644<br>
--- a/src/intel/isl/isl_format_<wbr>layout.csv<br>
+++ b/src/intel/isl/isl_format_<wbr>layout.csv<br>
@@ -96,7 +96,6 @@ X32_TYPELESS_G8X24_UINT , 64, 1, 1, 1, x32, ui8, x24, , ,<br>
L32A32_FLOAT , 64, 1, 1, 1, , , , sf32, sf32, , , linear,<br>
R32G32_UNORM , 64, 1, 1, 1, un32, un32, , , , , , linear,<br>
R32G32_SNORM , 64, 1, 1, 1, sn32, sn32, , , , , , linear,<br>
-R64_FLOAT , 64, 1, 1, 1, sf64, , , , , , , linear,<br>
R16G16B16X16_UNORM , 64, 1, 1, 1, un16, un16, un16, x16, , , , linear,<br>
R16G16B16X16_FLOAT , 64, 1, 1, 1, sf16, sf16, sf16, x16, , , , linear,<br>
A32X32_FLOAT , 64, 1, 1, 1, , , , sf32, x32, , , alpha,<br>
@@ -243,8 +242,6 @@ R8G8B8_UNORM , 24, 1, 1, 1, un8, un8, un8, , ,<br>
R8G8B8_SNORM , 24, 1, 1, 1, sn8, sn8, sn8, , , , , linear,<br>
R8G8B8_SSCALED , 24, 1, 1, 1, ss8, ss8, ss8, , , , , linear,<br>
R8G8B8_USCALED , 24, 1, 1, 1, us8, us8, us8, , , , , linear,<br>
-R64G64B64A64_FLOAT , 256, 1, 1, 1, sf64, sf64, sf64, sf64, , , , linear,<br>
-R64G64B64_FLOAT , 196, 1, 1, 1, sf64, sf64, sf64, , , , , linear,<br></blockquote><div><br></div><div>Why are we deleting these three formats? Do they not exist? Are their entries wrong? The isl_format_layout table contains information for several formats that are unused in either driver. I'd rather leave them here unless they are causing a problem.<br></div><div> </div></div></div></div></blockquote><div><br></div><div>OK, then we will keep them. I was deleting them because they were unused but you are right.</div><div><br></div><div>Sam</div><div><br></div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote type="cite">
BC4_SNORM , 64, 4, 4, 1, sn8, , , , , , , linear, rgtc1<br>
BC5_SNORM , 128, 4, 4, 1, sn8, sn8, , , , , , linear, rgtc2<br>
R16G16B16_FLOAT , 48, 1, 1, 1, sf16, sf16, sf16, , , , , linear,<br>
diff --git a/src/intel/vulkan/anv_<wbr>formats.c b/src/intel/vulkan/anv_<wbr>formats.c<br>
index 9ef998c..39810d4 100644<br>
--- a/src/intel/vulkan/anv_<wbr>formats.c<br>
+++ b/src/intel/vulkan/anv_<wbr>formats.c<br>
@@ -156,16 +156,16 @@ static const struct anv_format anv_formats[] = {<br>
fmt(VK_FORMAT_R32G32B32A32_<wbr>SFLOAT, ISL_FORMAT_R32G32B32A32_FLOAT)<wbr>,<br>
fmt(VK_FORMAT_R64_UINT, ISL_FORMAT_R64_PASSTHRU),<br>
fmt(VK_FORMAT_R64_SINT, ISL_FORMAT_R64_PASSTHRU),<br>
- fmt(VK_FORMAT_R64_SFLOAT, ISL_FORMAT_R64_FLOAT),<br>
+ fmt(VK_FORMAT_R64_SFLOAT, ISL_FORMAT_R64_PASSTHRU),<br>
fmt(VK_FORMAT_R64G64_UINT, ISL_FORMAT_R64G64_PASSTHRU),<br>
fmt(VK_FORMAT_R64G64_SINT, ISL_FORMAT_R64G64_PASSTHRU),<br>
- fmt(VK_FORMAT_R64G64_SFLOAT, ISL_FORMAT_R64G64_FLOAT),<br>
+ fmt(VK_FORMAT_R64G64_SFLOAT, ISL_FORMAT_R64G64_PASSTHRU),<br>
fmt(VK_FORMAT_R64G64B64_UINT, ISL_FORMAT_R64G64B64_PASSTHRU)<wbr>,<br>
fmt(VK_FORMAT_R64G64B64_SINT, ISL_FORMAT_R64G64B64_PASSTHRU)<wbr>,<br>
- fmt(VK_FORMAT_R64G64B64_<wbr>SFLOAT, ISL_FORMAT_R64G64B64_FLOAT),<br>
+ fmt(VK_FORMAT_R64G64B64_<wbr>SFLOAT, ISL_FORMAT_R64G64B64_PASSTHRU)<wbr>,<br>
fmt(VK_FORMAT_R64G64B64A64_<wbr>UINT, ISL_FORMAT_R64G64B64A64_<wbr>PASSTHRU),<br>
fmt(VK_FORMAT_R64G64B64A64_<wbr>SINT, ISL_FORMAT_R64G64B64A64_<wbr>PASSTHRU),<br>
- fmt(VK_FORMAT_R64G64B64A64_<wbr>SFLOAT, ISL_FORMAT_R64G64B64A64_FLOAT)<wbr>,<br>
+ fmt(VK_FORMAT_R64G64B64A64_<wbr>SFLOAT, ISL_FORMAT_R64G64B64A64_<wbr>PASSTHRU),<br>
fmt(VK_FORMAT_B10G11R11_<wbr>UFLOAT_PACK32, ISL_FORMAT_R11G11B10_FLOAT),<br>
fmt(VK_FORMAT_E5B9G9R9_UFLOAT_<wbr>PACK32, ISL_FORMAT_R9G9B9E5_SHAREDEXP)<wbr>,<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span><br></blockquote></div><br></div></div>
<pre>_______________________________________________
mesa-dev mailing list
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>
</pre></blockquote></body></html>