<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Dec 4, 2016 11:18 PM, "Pohjolainen, Topi" <<a href="mailto:topi.pohjolainen@gmail.com">topi.pohjolainen@gmail.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="quoted-text">On Sun, Dec 04, 2016 at 08:36:03PM -0800, Jason Ekstrand wrote:<br>
>    On Sun, Dec 4, 2016 at 2:08 PM, Topi Pohjolainen<br>
</div><div class="quoted-text">>    <[1]<a href="mailto:topi.pohjolainen@gmail.com">topi.pohjolainen@gmail.com</a><wbr>> wrote:<br>
><br>
>      Otherwise subsequent render cycles keep on using compression<br>
>      and/or fast clear.<br>
><br>
>    I believe that's because most things look at mt->mcs_buf rather than<br>
>    no_ccs.  Given that we're allocating the CCS up-front, is no_ccs really<br>
>    doing anything for us or can we just use mt->mcs_buf?  Maybe it's<br>
>    mostly used during miptree setup?<br>
<br>
</div>You are correct that only setup looks no_ccs and the rest mt->mcs_buf. Then<br>
about the allocation. For compression the allocation is up-front, but for<br>
plain-old-fast-clear we still allocate on-demand.<br></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Ah. I didn't realize that</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
><br>
>      Signed-off-by: Topi Pohjolainen <[2]<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a><wbr>><br>
>      CC: Kalyan Kondapally <[3]<a href="mailto:kalyan.kondapally@intel.com">kalyan.kondapally@intel.<wbr>com</a>><br>
>      CC: Kenneth Graunke <[4]<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
<div class="quoted-text">>      ---<br>
>       src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c | 3 +++<br>
>       1 file changed, 3 insertions(+)<br>
>      diff --git a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
>      b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
>      index a9b350e..7cda019 100644<br>
>      --- a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
>      +++ b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
>      @@ -2326,6 +2326,9 @@ intel_miptree_make_shareable(<wbr>struct<br>
>      brw_context *brw,<br>
>          if (mt->mcs_buf) {<br>
>             intel_miptree_all_slices_<wbr>resolve_color(brw, mt, 0);<br>
>             mt->no_ccs = true;<br>
>      +      drm_intel_bo_unreference(mt-><wbr>mcs_buf->bo);<br>
>      +      free(mt->mcs_buf);<br>
>      +      mt->mcs_buf = NULL;<br>
>          }<br>
>       }<br>
>      --<br>
>      2.5.5<br>
>      ______________________________<wbr>_________________<br>
>      mesa-dev mailing list<br>
</div>>      [5]<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.<wbr>org</a><br>
>      [6]<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.<wbr>org/mailman/listinfo/mesa-dev</a><br>
><br>
> References<br>
><br>
>    1. mailto:<a href="mailto:topi.pohjolainen@gmail.com">topi.pohjolainen@gmail.<wbr>com</a><br>
>    2. mailto:<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.<wbr>com</a><br>
>    3. mailto:<a href="mailto:kalyan.kondapally@intel.com">kalyan.kondapally@<wbr>intel.com</a><br>
>    4. mailto:<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a><br>
>    5. mailto:<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.<wbr>freedesktop.org</a><br>
>    6. <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div></div>