<div dir="ltr">Calling exit() is going to cause the program to terminate and all of its resources will get cleaned up by the OS. There's no real reason why we need to free anything first. </div><div class="gmail_extra"> <div class="gmail_quote">On Sun, Dec 4, 2016 at 9:47 AM, Nayan Deshmukh <<a href="mailto:nayan26deshmukh@gmail.com" target="_blank">nayan26deshmukh@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">CovID: 1373563 Signed-off-by: Nayan Deshmukh <<a href="mailto:nayan26deshmukh@gmail.com">nayan26deshmukh@gmail.com</a>> --- src/intel/tools/aubinator.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 5e3a684..f64a843 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c @@ -959,25 +959,28 @@ aub_file_open(const char *filename) fd = open(filename, O_RDONLY); if (fd == -1) { fprintf(stderr, "open %s failed: %s\n", filename, strerror(errno)); - exit(EXIT_FAILURE); + goto exit_failure; } if (fstat(fd, &sb) == -1) { fprintf(stderr, "stat failed: %s\n", strerror(errno)); - exit(EXIT_FAILURE); + goto exit_failure; } file->map = mmap(NULL, sb.st_size, PROT_READ, MAP_SHARED, fd, 0); if (file->map == MAP_FAILED) { fprintf(stderr, "mmap failed: %s\n", strerror(errno)); - exit(EXIT_FAILURE); + goto exit_failure; } file->cursor = file->map; file->end = file->map + sb.st_size / 4; return file; +exit_failure: + free(file); + exit(EXIT_FAILURE); } static struct aub_file * -- 2.9.3 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>