<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Dec 22, 2016 at 11:58 AM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra">I'm not actually sure that we need this anymore. We never run convert_to_lcssa unless we are about to make actual CF modifications and, therefore, report progress. I've got a patch running through Jenkins now to find out. I'm not strongly opposed to keeping it but I'd like to know if it's really needed.<br></div></blockquote><div><br></div><div>Jenkins came back green. It's not needed.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote">On Wed, Dec 21, 2016 at 6:26 PM, Timothy Arceri <span dir="ltr"><<a href="mailto:timothy.arceri@collabora.com" target="_blank">timothy.arceri@collabora.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">V2:<br>
- make the is_lcssa_phi bool const, suggested by Topi.<br>
---<br>
src/compiler/nir/nir_opt_remo<wbr>ve_phis.c | 4 +++-<br>
1 file changed, 3 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/compiler/nir/nir_opt_rem<wbr>ove_phis.c b/src/compiler/nir/nir_opt_rem<wbr>ove_phis.c<br>
index acaa6e1..99d5d35 100644<br>
--- a/src/compiler/nir/nir_opt_rem<wbr>ove_phis.c<br>
+++ b/src/compiler/nir/nir_opt_rem<wbr>ove_phis.c<br>
@@ -73,6 +73,7 @@ remove_phis_block(nir_block *block, nir_builder *b)<br>
break;<br>
<br>
nir_phi_instr *phi = nir_instr_as_phi(instr);<br>
+ const bool is_lcssa_phi = phi->is_lcssa_phi;<br>
<br>
nir_ssa_def *def = NULL;<br>
nir_alu_instr *mov = NULL;<br>
@@ -133,7 +134,8 @@ remove_phis_block(nir_block *block, nir_builder *b)<br>
nir_ssa_def_rewrite_uses(&<wbr>phi->dest.ssa, nir_src_for_ssa(def));<br>
nir_instr_remove(instr);<br>
<br>
- progress = true;<br>
+ if (!is_lcssa_phi)<br>
+ progress = true;<br>
}<br>
<br>
return progress;<br>
<span class="m_2163760628774869787HOEnZb"><font color="#888888">--<br>
2.9.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div><div class="HOEnZb"><div class="h5">
</div></div></blockquote></div><br></div></div>