<div dir="ltr">Nak. From the Vulkan spec 1.0.37, valid usage for vkGetSwapchainimagesKHR: <ul class="gmail-itemizedlist"><li class="gmail-listitem"> <code>swapchain</code> must be a valid <code class="gmail-code">VkSwapchainKHR</code> handle </li></ul>We don't silently handle invalid usage. </div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Dec 22, 2016 at 9:30 AM, Arda Coskunses <<a href="mailto:acoskunses@gmail.com" target="_blank">acoskunses@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">When application window closed unexpectedly anv_GetSwapchainImagesKHR function getting called with invlid parameters which cause a crash. Necessary Null check added --- src/intel/vulkan/anv_wsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c index 669eacc..1e05daf 100644 --- a/src/intel/vulkan/anv_wsi.c +++ b/src/intel/vulkan/anv_wsi.c @@ -320,6 +320,9 @@ VkResult anv_GetSwapchainImagesKHR( { ANV_FROM_HANDLE(wsi_swapchain, swapchain, _swapchain); + if(!swapchain) + return VK_INCOMPLETE; + return swapchain->get_images(swapchain, pSwapchainImageCount, pSwapchainImages); } -- 2.7.4 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>