<div dir="auto">Ugh... The problem is that we have to set the surface up differently for write-only surfaces. We should shut it off for now.</div><div class="gmail_extra"><br><div class="gmail_quote">On Dec 29, 2016 11:01 PM, "Ilia Mirkin" <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Well, maybe not, but<br>
<br>
src/amd/vulkan/radv_device.c:<br>
.<wbr>shaderStorageImageWriteWithout<wbr>Format = true,<br>
src/intel/vulkan/anv_device.c:<br>
.<wbr>shaderStorageImageWriteWithout<wbr>Format = true,<br>
<br>
and from a brief look at the code, it seems like it should work -<br>
image_format gets set to 0 (GL_NONE), which is exactly what happens in<br>
the GLSL path. I noticed this when adding ImageReadWithoutFormat for<br>
gen9+, but sadly there are no tests for either of those.<br>
<br>
-ilia<br>
<br>
On Thu, Dec 29, 2016 at 11:57 PM, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br>
> I don't think we actually do...<br>
><br>
> On Dec 29, 2016 9:34 PM, "Ilia Mirkin" <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> wrote:<br>
>><br>
>> Both anv and radv support this.<br>
>><br>
>> Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>><br>
>> ---<br>
>> src/compiler/spirv/spirv_to_<wbr>nir.c | 2 +-<br>
>> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
>><br>
>> diff --git a/src/compiler/spirv/spirv_to_<wbr>nir.c<br>
>> b/src/compiler/spirv/spirv_to_<wbr>nir.c<br>
>> index 07980aa..22e14f6 100644<br>
>> --- a/src/compiler/spirv/spirv_to_<wbr>nir.c<br>
>> +++ b/src/compiler/spirv/spirv_to_<wbr>nir.c<br>
>> @@ -2507,6 +2507,7 @@ vtn_handle_preamble_<wbr>instruction(struct vtn_builder<br>
>> *b, SpvOp opcode,<br>
>> case SpvCapabilityInputAttachment:<br>
>> case SpvCapabilityImageGatherExtend<wbr>ed:<br>
>> case SpvCapabilityStorageImageExten<wbr>dedFormats:<br>
>> + case SpvCapabilityStorageImageWrite<wbr>WithoutFormat:<br>
>> break;<br>
>><br>
>> case SpvCapabilityGeometryStreams:<br>
>> @@ -2528,7 +2529,6 @@ vtn_handle_preamble_<wbr>instruction(struct vtn_builder<br>
>> *b, SpvOp opcode,<br>
>> case SpvCapabilityMinLod:<br>
>> case SpvCapabilityTransformFeedback<wbr>:<br>
>> case SpvCapabilityStorageImageReadW<wbr>ithoutFormat:<br>
>> - case SpvCapabilityStorageImageWrite<wbr>WithoutFormat:<br>
>> vtn_warn("Unsupported SPIR-V capability: %s",<br>
>> spirv_capability_to_string(<wbr>cap));<br>
>> break;<br>
>> --<br>
>> 2.10.2<br>
>><br>
>> ______________________________<wbr>_________________<br>
>> mesa-dev mailing list<br>
>> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
>> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div>