<div dir="ltr">ack<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 29, 2016 at 10:01 PM, Dave Airlie <span dir="ltr"><<a href="mailto:airlied@gmail.com" target="_blank">airlied@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 30 December 2016 at 15:52, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> wrote:<br>
> The SPIR-V capability isn't even marked as enabled, and there are no<br>
> tests in Vulkan-CTS. Per Jason Ekstrand, this won't work in anv as such<br>
> write-only surfaces require additional setup which is currently not<br>
> performed.<br>
><br>
> Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>><br>
<br>
</span>Acked-by: Dave Airlie <<a href="mailto:airlied@redhat.com">airlied@redhat.com</a>><br>
<br>
just remind me when tests show up :-)<br>
<div><div class="h5"><br>
> ---<br>
><br>
> I don't care whether this patch or the one to enable the SPIR-V cap goes in.<br>
> However the current state is inconsistent. We can even make use of the new<br>
> SPIR-V extensions capability if radv wants it on while anv wants it off.<br>
><br>
>  src/amd/vulkan/radv_device.c  | 2 +-<br>
>  src/intel/vulkan/anv_device.c | 2 +-<br>
>  2 files changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c<br>
> index dcbb015..e57a419 100644<br>
> --- a/src/amd/vulkan/radv_device.c<br>
> +++ b/src/amd/vulkan/radv_device.c<br>
> @@ -403,7 +403,7 @@ void radv_<wbr>GetPhysicalDeviceFeatures(<br>
>                 .<wbr>shaderStorageBufferArrayDynami<wbr>cIndexing  = true,<br>
>                 .<wbr>shaderStorageImageArrayDynamic<wbr>Indexing   = true,<br>
>                 .<wbr>shaderStorageImageReadWithoutF<wbr>ormat      = false,<br>
> -               .<wbr>shaderStorageImageWriteWithout<wbr>Format     = true,<br>
> +               .<wbr>shaderStorageImageWriteWithout<wbr>Format     = false,<br>
>                 .shaderClipDistance                       = true,<br>
>                 .shaderCullDistance                       = true,<br>
>                 .shaderFloat64                            = false,<br>
> diff --git a/src/intel/vulkan/anv_device.<wbr>c b/src/intel/vulkan/anv_device.<wbr>c<br>
> index ec1e0e8..69e1dc2 100644<br>
> --- a/src/intel/vulkan/anv_device.<wbr>c<br>
> +++ b/src/intel/vulkan/anv_device.<wbr>c<br>
> @@ -472,7 +472,7 @@ void anv_GetPhysicalDeviceFeatures(<br>
>        .<wbr>shaderStorageImageExtendedForm<wbr>ats        = true,<br>
>        .shaderStorageImageMultisample            = false,<br>
>        .<wbr>shaderStorageImageReadWithoutF<wbr>ormat      = false,<br>
> -      .<wbr>shaderStorageImageWriteWithout<wbr>Format     = true,<br>
> +      .<wbr>shaderStorageImageWriteWithout<wbr>Format     = false,<br>
>        .<wbr>shaderUniformBufferArrayDynami<wbr>cIndexing  = true,<br>
>        .<wbr>shaderSampledImageArrayDynamic<wbr>Indexing   = true,<br>
>        .<wbr>shaderStorageBufferArrayDynami<wbr>cIndexing  = true,<br>
> --<br>
> 2.10.2<br>
><br>
</div></div>> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div>