<div dir="ltr"><div><div>1-5 and 7-11 are </div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div>I left a few trivial comments on them but nothing substantial. </div><div class="gmail_extra"> <div class="gmail_quote">On Fri, Dec 16, 2016 at 6:48 AM, Juan A. Suarez Romero <<a href="mailto:jasuarez@igalia.com" target="_blank">jasuarez@igalia.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This patch series is a second iteration of previous one: <a href="https://lists.freedesktop.org/archives/mesa-dev/2016-November/136507.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2016-November/136507.html</a> Main changes are the ones suggested by Jason, and also a refactor of the way inputs_read bitmap is used in NIR. If you want to test these patches, you can clone our branch with the following command: $ git clone -b spirv-to-nir-rc2 <a href="https://github.com/Igalia/mesa.github" rel="noreferrer" target="_blank">https://github.com/Igalia/mesa.github</a> Thanks, J.A. Juan A. Suarez Romero (2): anv/pipeline: get map for double input attributes nir/i965: use two slots from inputs_read for dvec3/dvec4 vertex input attributes Samuel Iglesias Gonsálvez (23): spirv: fix typo in spec_constant_decoration_cb() spirv: add definition of double based data types spirv: add support for loading DF constants spirv: add DF support to vtn_const_ssa_value() spirv: add DF support to SpvOp*ConstantComposite spirv: fix SpvOpSpecConstantOp with SpvOpVectorShuffle working with double-based vecs spirv: add double support to SpvOpCompositeExtract spirv: add double support to _vtn_variable_load_store spirv: add double support to _vtn_block_load_store() spirv: Enable double floating points when copying variables in _vtn_variable_copy() spirv: add support for doubles on OpComposite{Insert,Extract} compiler/nir: add glsl_type_is_{float,integer}() nir: add nir_get_nir_type_for_glsl_type() nir: add nir_type_conversion_op() spirv/nir: implement DF conversions spirv/nir: add (un)packDouble2x32() translation spirv: add support for doubles to OpSpecConstant isl: fix VA64 support for double and dvecN vertex attributes nir: Add flag to detect platforms with native float64 support spirv: Add nir_options to vtn_builder spirv: enable SpvCapabilityFloat64 only to supported platforms i965: enable nir_option's native_float64 to supported generations anv: enable shaderFloat64 feature src/amd/vulkan/radv_pipeline.c | 5 +- src/compiler/glsl/glsl_to_nir.cpp | 28 ++++++ src/compiler/nir/nir.c | 83 ++++++++++++++++ src/compiler/nir/nir.h | 26 +++++ src/compiler/nir/nir_gather_info.c | 48 +++++---- src/compiler/nir_types.cpp | 15 +++ src/compiler/nir_types.h | 2 + src/compiler/spirv/nir_spirv.h | 5 +- src/compiler/spirv/spirv_to_nir.c | 141 ++++++++++++++++++++++----- src/compiler/spirv/vtn_alu.c | 29 +++--- src/compiler/spirv/vtn_glsl450.c | 2 + src/compiler/spirv/vtn_private.h | 4 +- src/compiler/spirv/vtn_variables.c | 3 + src/intel/isl/isl_format.c | 4 +- src/intel/isl/isl_format_layout.csv | 1 - src/intel/vulkan/anv_device.c | 2 +- src/intel/vulkan/anv_formats.c | 8 +- src/intel/vulkan/anv_pipeline.c | 6 +- src/intel/vulkan/genX_pipeline.c | 63 +++++++----- src/mesa/drivers/dri/i965/brw_compiler.c | 36 ++++--- src/mesa/drivers/dri/i965/brw_draw_upload.c | 11 ++- src/mesa/drivers/dri/i965/brw_fs.cpp | 13 --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 +- src/mesa/drivers/dri/i965/brw_nir.c | 6 +- src/mesa/drivers/dri/i965/brw_nir.h | 1 - src/mesa/drivers/dri/i965/brw_vec4.cpp | 11 +-- 26 files changed, 419 insertions(+), 137 deletions(-) -- 2.9.3 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>