<div dir="ltr">14-18 and 22 are<br><br><div class="gmail_quote">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div><div class="gmail_quote">I'd like to see the way we're enabling it for SPIR-V reworked to use the new struct Dave added. Overall, looks really good.<br></div><div class="gmail_quote">--Jason<br></div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 3, 2017 at 4:32 AM, Samuel Iglesias Gonsálvez <span dir="ltr"><<a href="mailto:siglesias@igalia.com" target="_blank">siglesias@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, 2017-01-02 at 10:20 -0800, Jason Ekstrand wrote:<br>
> 1-5 and 7-11 are<br>
><br>
> Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br>
><br>
> I left a few trivial comments on them but nothing substantial.<br>
><br>
<br>
</span>OK, I will fix them.<br>
<br>
Thanks for the review,<br>
<br>
Sam<br>
<div class="HOEnZb"><div class="h5"><br>
> On Fri, Dec 16, 2016 at 6:48 AM, Juan A. Suarez Romero<br>
> <<a href="mailto:jasuarez@igalia.com">jasuarez@igalia.com</a>> wrote:<br>
> > This patch series is a second iteration of previous one:<br>
> ><br>
> > <a href="https://lists.freedesktop.org/archives/mesa-dev/2016-November/13650" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>archives/mesa-dev/2016-<wbr>November/13650</a><br>
> > 7.html<br>
> ><br>
> > Main changes are the ones suggested by Jason, and also a refactor<br>
> > of the way<br>
> > inputs_read bitmap is used in NIR.<br>
> ><br>
> > If you want to test these patches, you can clone our branch with<br>
> > the following<br>
> > command:<br>
> ><br>
> > $ git clone -b spirv-to-nir-rc2 <a href="https://github.com/Igalia/mesa.g" rel="noreferrer" target="_blank">https://github.com/Igalia/<wbr>mesa.g</a><br>
> > ithub<br>
> ><br>
> > Thanks,<br>
> ><br>
> > J.A.<br>
> ><br>
> ><br>
> ><br>
> > Juan A. Suarez Romero (2):<br>
> > anv/pipeline: get map for double input attributes<br>
> > nir/i965: use two slots from inputs_read for dvec3/dvec4 vertex<br>
> > input<br>
> > attributes<br>
> ><br>
> > Samuel Iglesias Gonsálvez (23):<br>
> > spirv: fix typo in spec_constant_decoration_cb()<br>
> > spirv: add definition of double based data types<br>
> > spirv: add support for loading DF constants<br>
> > spirv: add DF support to vtn_const_ssa_value()<br>
> > spirv: add DF support to SpvOp*ConstantComposite<br>
> > spirv: fix SpvOpSpecConstantOp with SpvOpVectorShuffle working<br>
> > with<br>
> > double-based vecs<br>
> > spirv: add double support to SpvOpCompositeExtract<br>
> > spirv: add double support to _vtn_variable_load_store<br>
> > spirv: add double support to _vtn_block_load_store()<br>
> > spirv: Enable double floating points when copying variables in<br>
> > _vtn_variable_copy()<br>
> > spirv: add support for doubles on OpComposite{Insert,Extract}<br>
> > compiler/nir: add glsl_type_is_{float,integer}()<br>
> > nir: add nir_get_nir_type_for_glsl_<wbr>type()<br>
> > nir: add nir_type_conversion_op()<br>
> > spirv/nir: implement DF conversions<br>
> > spirv/nir: add (un)packDouble2x32() translation<br>
> > spirv: add support for doubles to OpSpecConstant<br>
> > isl: fix VA64 support for double and dvecN vertex attributes<br>
> > nir: Add flag to detect platforms with native float64 support<br>
> > spirv: Add nir_options to vtn_builder<br>
> > spirv: enable SpvCapabilityFloat64 only to supported platforms<br>
> > i965: enable nir_option's native_float64 to supported generations<br>
> > anv: enable shaderFloat64 feature<br>
> ><br>
> > src/amd/vulkan/radv_pipeline.<wbr>c | 5 +-<br>
> > src/compiler/glsl/glsl_to_<wbr>nir.cpp | 28 ++++++<br>
> > src/compiler/nir/nir.c | 83<br>
> > ++++++++++++++++<br>
> > src/compiler/nir/nir.h | 26 +++++<br>
> > src/compiler/nir/nir_gather_<wbr>info.c | 48 +++++----<br>
> > src/compiler/nir_types.cpp | 15 +++<br>
> > src/compiler/nir_types.h | 2 +<br>
> > src/compiler/spirv/nir_spirv.<wbr>h | 5 +-<br>
> > src/compiler/spirv/spirv_to_<wbr>nir.c | 141<br>
> > ++++++++++++++++++++++-----<br>
> > src/compiler/spirv/vtn_alu.c | 29 +++---<br>
> > src/compiler/spirv/vtn_<wbr>glsl450.c | 2 +<br>
> > src/compiler/spirv/vtn_<wbr>private.h | 4 +-<br>
> > src/compiler/spirv/vtn_<wbr>variables.c | 3 +<br>
> > src/intel/isl/isl_format.c | 4 +-<br>
> > src/intel/isl/isl_format_<wbr>layout.csv | 1 -<br>
> > src/intel/vulkan/anv_device.<wbr>c | 2 +-<br>
> > src/intel/vulkan/anv_formats.<wbr>c | 8 +-<br>
> > src/intel/vulkan/anv_<wbr>pipeline.c | 6 +-<br>
> > src/intel/vulkan/genX_<wbr>pipeline.c | 63 +++++++-----<br>
> > src/mesa/drivers/dri/i965/<wbr>brw_compiler.c | 36 ++++---<br>
> > src/mesa/drivers/dri/i965/<wbr>brw_draw_upload.c | 11 ++-<br>
> > src/mesa/drivers/dri/i965/<wbr>brw_fs.cpp | 13 ---<br>
> > src/mesa/drivers/dri/i965/<wbr>brw_fs_visitor.cpp | 3 +-<br>
> > src/mesa/drivers/dri/i965/<wbr>brw_nir.c | 6 +-<br>
> > src/mesa/drivers/dri/i965/<wbr>brw_nir.h | 1 -<br>
> > src/mesa/drivers/dri/i965/<wbr>brw_vec4.cpp | 11 +--<br>
> > 26 files changed, 419 insertions(+), 137 deletions(-)<br>
> ><br>
> > --<br>
> > 2.9.3<br>
> ><br>
> > ______________________________<wbr>_________________<br>
> > mesa-dev mailing list<br>
> > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
> ><br>
><br>
> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a></div></div></blockquote></div><br></div>