<div dir="auto">Thanks for catching this. I wonder how I managed to switch the GL driver over to using ISL for emitting surface states without regressing anything...<div dir="auto"><br></div><div dir="auto">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Jan 6, 2017 05:42, "Iago Toral Quiroga" <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This fixes layered rendering Vulkan CTS tests with cube (arrays). We<br>
also do this in the GL driver, see this code from gen8_depth_state.c<br>
for example:<br>
<br>
case GL_TEXTURE_CUBE_MAP_ARRAY:<br>
case GL_TEXTURE_CUBE_MAP:<br>
/* The PRM claims that we should use BRW_SURFACE_CUBE for this<br>
* situation, but experiments show that gl_Layer doesn't work when we do<br>
* this. So we use BRW_SURFACE_2D, since for rendering purposes this is<br>
* equivalent.<br>
*/<br>
surftype = BRW_SURFACE_2D;<br>
depth *= 6;<br>
break;<br>
<br>
So I guess we simply forgot to port this workaround to Vulkan.<br>
<br>
Fixes:<br>
dEQP-VK.geometry.layered.cube*<br>
---<br>
<br>
With this (and the previous patch I sent to fix the SBE state packet to not<br>
skip the VUE header when we need the layer information) all the layered<br>
rendering tests in Vulkan CTS seem to pass.<br>
<br>
src/intel/isl/isl_surface_<wbr>state.c | 5 +++--<br>
1 file changed, 3 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/isl/isl_surface_<wbr>state.c b/src/intel/isl/isl_surface_<wbr>state.c<br>
index 3bb0abd..0960a90 100644<br>
--- a/src/intel/isl/isl_surface_<wbr>state.c<br>
+++ b/src/intel/isl/isl_surface_<wbr>state.c<br>
@@ -113,8 +113,9 @@ get_surftype(enum isl_surf_dim dim, isl_surf_usage_flags_t usage)<br>
assert(!(usage & ISL_SURF_USAGE_CUBE_BIT));<br>
return SURFTYPE_1D;<br>
case ISL_SURF_DIM_2D:<br>
- if (usage & ISL_SURF_USAGE_STORAGE_BIT) {<br>
- /* Storage images are always plain 2-D, not cube */<br>
+ if ((usage & ISL_SURF_USAGE_STORAGE_BIT) ||<br>
+ (usage & ISL_SURF_USAGE_RENDER_TARGET_<wbr>BIT)) {<br>
+ /* Storage / Render images are always plain 2-D, not cube */<br>
return SURFTYPE_2D;<br>
} else if (usage & ISL_SURF_USAGE_CUBE_BIT) {<br>
return SURFTYPE_CUBE;<br>
--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div>