<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2017-01-06 14:46 GMT-08:00 Nanley Chery <span dir="ltr"><<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">We currently don't perform clears or resolves on multiple array layers<br>
with HiZ.<br></blockquote><div><br></div><div>Glancing through the code, it looks like you're right.  I'm not even sure that you can do layered HiZ clears and/or resolves with the HZ op; you'd probably have to do it the gen7 way with blorp.  Thanks for catching this!<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.<wbr>org</a></blockquote><div><br></div><div>Do we have hiz in 13.1?  If not, it won't apply and Emil will reject it.<br><br>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br>
---<br>
 src/intel/vulkan/anv_image.c | 2 ++<br>
 1 file changed, 2 insertions(+)<br>
<br>
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c<br>
index e60373a151..f262d8a524 100644<br>
--- a/src/intel/vulkan/anv_image.c<br>
+++ b/src/intel/vulkan/anv_image.c<br>
@@ -186,6 +186,8 @@ make_surface(const struct anv_device *dev,<br>
          anv_finishme("Implement gen7 HiZ");<br>
       } else if (vk_info->mipLevels > 1) {<br>
          anv_finishme("Test multi-LOD HiZ");<br>
+      } else if (vk_info->arrayLayers > 1) {<br>
+         anv_finishme("Implement multi-arrayLayer HiZ clears and resolves");<br>
       } else if (dev->info.gen == 8 && vk_info->samples > 1) {<br>
          anv_finishme("Test gen8 multisampled HiZ");<br>
       } else {<br>
<span class="gmail-HOEnZb"><font color="#888888">--<br>
2.11.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>