<div dir="ltr"><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div>and pushed... Thanks! </div><div class="gmail_extra"> <div class="gmail_quote">On Mon, Jan 9, 2017 at 1:45 PM, Thomas Hindoe Paaboel Andersen <<a href="mailto:phomes@gmail.com" target="_blank">phomes@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The foreach loop was called both in the else case and right after. The indentation seems to indicate that the extra call was from a previous version with an else section with out curly brackets. --- Spotted due to the wrong indentation. The patch is untested as I do not have the neccesary hardware. src/compiler/nir/nir_from_ssa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler/nir/nir_from_ssa.c b/src/compiler/nir/nir_from_ssa.c index 2d8eed5..a8d3e64 100644 --- a/src/compiler/nir/nir_from_ssa.c +++ b/src/compiler/nir/nir_from_ssa.c @@ -970,7 +970,6 @@ nir_lower_ssa_defs_to_regs_block(nir_block *block) } else { nir_foreach_dest(instr, dest_replace_ssa_with_reg, &state); } - nir_foreach_dest(instr, dest_replace_ssa_with_reg, &state); } return state.progress; -- 2.9.3 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>