<div dir="auto">This will just cause shader based workarounds in the affected applications, no? What's the benefit of removing this? Fwiw, Nvidia hw has support for this.</div><div class="gmail_extra"><br><div class="gmail_quote">On Jan 10, 2017 9:59 AM, "Nicolai Hähnle" <<a href="mailto:nhaehnle@gmail.com">nhaehnle@gmail.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com">nicolai.haehnle@amd.com</a>><br>
<br>
Some parts of the extension were explicitly removed for core profiles,<br>
and all the remaining functionality has been in core since core profiles<br>
exist. So there's no loss of exposed functionality.<br>
<br>
The corresponding change was applied to i965 in 2013 (commit<br>
bd850cb4f2c77e2eb6716c865c40b9<wbr>976633fc23), so it's not like<br>
applications could be surprised by this behavior either.<br>
<br>
Fixes GL45-CTS.gtf30.GL3Tests.half_<wbr>float.half_float_textures.<br>
---<br>
src/mesa/state_tracker/st_<wbr>context.c | 16 ++++++----------<br>
1 file changed, 6 insertions(+), 10 deletions(-)<br>
<br>
diff --git a/src/mesa/state_tracker/st_<wbr>context.c b/src/mesa/state_tracker/st_<wbr>context.c<br>
index 0eae971..a2df704 100644<br>
--- a/src/mesa/state_tracker/st_<wbr>context.c<br>
+++ b/src/mesa/state_tracker/st_<wbr>context.c<br>
@@ -450,32 +450,28 @@ st_create_context_priv( struct gl_context *ctx, struct pipe_context *pipe,<br>
<br>
/* Enable shader-based fallbacks for ARB_color_buffer_float if needed. */<br>
if (screen->get_param(screen, PIPE_CAP_VERTEX_COLOR_<wbr>UNCLAMPED)) {<br>
if (!screen->get_param(screen, PIPE_CAP_VERTEX_COLOR_CLAMPED)<wbr>) {<br>
st->clamp_vert_color_in_shader = GL_TRUE;<br>
}<br>
<br>
if (!screen->get_param(screen, PIPE_CAP_FRAGMENT_COLOR_<wbr>CLAMPED)) {<br>
st->clamp_frag_color_in_shader = GL_TRUE;<br>
}<br>
-<br>
- /* For drivers which cannot do color clamping, it's better to just<br>
- * disable ARB_color_buffer_float in the core profile, because<br>
- * the clamping is deprecated there anyway. */<br>
- if (ctx->API == API_OPENGL_CORE &&<br>
- (st->clamp_frag_color_in_<wbr>shader || st->clamp_vert_color_in_<wbr>shader)) {<br>
- st->clamp_vert_color_in_shader = GL_FALSE;<br>
- st->clamp_frag_color_in_shader = GL_FALSE;<br>
- ctx->Extensions.ARB_color_<wbr>buffer_float = GL_FALSE;<br>
- }<br>
}<br>
<br>
+ /* Disable ARB_color_buffer_float for core contexts, since some of its<br>
+ * functionality was explicitly removed.<br>
+ */<br>
+ if (ctx->API == API_OPENGL_CORE)<br>
+ ctx->Extensions.ARB_color_<wbr>buffer_float = GL_FALSE;<br>
+<br>
/* called after _mesa_create_context/_mesa_<wbr>init_point, fix default user<br>
* settable max point size up<br>
*/<br>
ctx->Point.MaxSize = MAX2(ctx->Const.MaxPointSize,<br>
ctx->Const.MaxPointSizeAA);<br>
/* For vertex shaders, make sure not to emit saturate when SM 3.0 is not supported */<br>
ctx->Const.<wbr>ShaderCompilerOptions[MESA_<wbr>SHADER_VERTEX].EmitNoSat = !st->has_shader_model3;<br>
<br>
if (!ctx->Extensions.ARB_gpu_<wbr>shader5) {<br>
for (i = 0; i < MESA_SHADER_STAGES; i++)<br>
<font color="#888888">--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></blockquote></div><br></div>