<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Wed, Jan 11, 2017 at 5:25 PM, Timothy Arceri <<a href="mailto:timothy.arceri@collabora.com" target="_blank">timothy.arceri@collabora.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, 2017-01-11 at 16:09 -0800, Kenneth Graunke wrote: > When multiple shader stages exist in the same SPIR-V module, we > compile > all entry points and their inputs/outputs, then dead code eliminate > the > ones not related to the specific entry point later. > > nir_lower_wpos_center was being run prior to eliminating those random > other variables, which made it trip up, thinking it found > gl_FragCoord > when it actually found something else like gl_PerVertex[3]. > > Fixes dEQP-VK.spirv_assembly.instruction.graphics.module.same_module. > > Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> Reviewed-by: Timothy Arceri <<a href="mailto:timothy.arceri@collabora.com">timothy.arceri@collabora.com</a>> <div class="HOEnZb"><div class="h5"> > --- > src/intel/vulkan/anv_pipeline.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/intel/vulkan/anv_pipeline.c > b/src/intel/vulkan/anv_pipeline.c > index 6c939b071da..7d939ebabe9 100644 > --- a/src/intel/vulkan/anv_pipeline.c > +++ b/src/intel/vulkan/anv_pipeline.c > @@ -139,9 +139,6 @@ anv_shader_compile_to_nir(struct anv_device > *device, > > free(spec_entries); > > - if (stage == MESA_SHADER_FRAGMENT) > - NIR_PASS_V(nir, nir_lower_wpos_center); > - > /* We have to lower away local constant initializers right before > we > * inline functions. That way they get properly initialized at > the top > * of the function and not at the top of its caller. > @@ -161,6 +158,9 @@ anv_shader_compile_to_nir(struct anv_device > *device, > NIR_PASS_V(nir, nir_remove_dead_variables, > nir_var_shader_in | nir_var_shader_out | > nir_var_system_value); > > + if (stage == MESA_SHADER_FRAGMENT) > + NIR_PASS_V(nir, nir_lower_wpos_center); > + > /* Now that we've deleted all but the main function, we can go > ahead and > * lower the rest of the constant initializers. > */ </div></div><div class="HOEnZb"><div class="h5">_______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </div></div></blockquote></div> </div>