<div dir="ltr">I would rather not... Those asserts exist precisely to prevent someone from doing a blorp copy with HiZ enabled when it's not actually supported. The right thing to do is to set aux_usage to ISL_AUX_USAGE_NONE if you want blorp to ignore aux. </div><div class="gmail_extra"> <div class="gmail_quote">On Wed, Jan 11, 2017 at 5:54 PM, Nanley Chery <<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Prevent assert failures that would occur in the next patch. BLORP ignores this flag internally, so no protections are lost here. Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>> --- src/intel/blorp/blorp_blit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 1cbd9403c9..aa389dbcc1 100644 --- a/src/intel/blorp/blorp_blit.c +++ b/src/intel/blorp/blorp_blit.c @@ -2291,9 +2291,11 @@ blorp_copy(struct blorp_batch *batch, isl_format_get_layout(params.dst.surf.format); assert(params.src.aux_usage == ISL_AUX_USAGE_NONE || + params.src.aux_usage == ISL_AUX_USAGE_HIZ || params.src.aux_usage == ISL_AUX_USAGE_MCS || params.src.aux_usage == ISL_AUX_USAGE_CCS_E); assert(params.dst.aux_usage == ISL_AUX_USAGE_NONE || + params.dst.aux_usage == ISL_AUX_USAGE_HIZ || params.dst.aux_usage == ISL_AUX_USAGE_MCS || params.dst.aux_usage == ISL_AUX_USAGE_CCS_E); -- 2.11.0 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>