<html><head></head><body><div>On Fri, 2017-01-13 at 08:29 -0800, Jason Ekstrand wrote:</div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Jan 13, 2017 at 1:33 AM, Samuel Iglesias Gonsálvez <span dir="ltr"><<a href="mailto:siglesias@igalia.com" target="_blank">siglesias@igalia.com</a>></span> wrote:<br><blockquote type="cite">Fixes crash in dEQP-VK.ubo.random.all_shared_<wbr>buffer.48 due to a<br>
fragment shader code bigger than 128 kB.<br>
<br>
This patch increases the allocation size limit to 256 kB.<br></blockquote><div><br></div><div>That limit will have to be changed two places. Where you did and also where we init the instruction_block_pool in anv_device.c<br></div><div> </div></div></div></div></blockquote><div><br></div><div>OK</div><div><br></div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote type="cite">
Signed-off-by: Samuel Iglesias Gonsálvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>><br>
---<br>
<br>
OpenGL driver compares the code size against the allocated cache buffer<br>
object size and allocates more if needed. I don't know how plausible<br>
is to have something similar in ANV instead of hardcoding the maximum<br>
size.<br>
<br>
Anyway, if setting it to 256 kB is too much for some reason, please discard<br>
this patch.<br>
<br>
src/intel/vulkan/anv_private.h | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_<wbr>private.h b/src/intel/vulkan/anv_<wbr>private.h<br>
index 2342fcbfeb4..cd3f17648dd 100644<br>
--- a/src/intel/vulkan/anv_<wbr>private.h<br>
+++ b/src/intel/vulkan/anv_<wbr>private.h<br>
@@ -393,7 +393,7 @@ struct anv_fixed_size_state_pool {<br>
};<br>
<br>
#define ANV_MIN_STATE_SIZE_LOG2 6<br>
-#define ANV_MAX_STATE_SIZE_LOG2 17<br>
+#define ANV_MAX_STATE_SIZE_LOG2 18<br></blockquote><div><br></div><div>Let's make it 1 MB while we're at it. I'm tired of bumping this.<br></div><div> </div></div></div></div></blockquote><div><br></div><div>OK! I will send a patch for this.</div><div><br></div><div>Sam</div><div><br></div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote type="cite">
<br>
#define ANV_STATE_BUCKETS (ANV_MAX_STATE_SIZE_LOG2 - ANV_MIN_STATE_SIZE_LOG2 + 1)<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.11.0<br>
<br>
</font></span><br></blockquote></div><br></div></div>
</blockquote></body></html>