<div dir="ltr"><div>Sure<br><br></div>Acked-by: Jason ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 18, 2017 at 2:49 PM, Andres Rodriguez <span dir="ltr"><<a href="mailto:andresx7@gmail.com" target="_blank">andresx7@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The current message sounds like a small warning, clarify that it can<br>
result in lack of presentation support and application crashes.<br>
<br>
Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=98263" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=98263</a><br>
Signed-off-by: Andres Rodriguez <<a href="mailto:andresx7@gmail.com">andresx7@gmail.com</a>><br>
---<br>
src/vulkan/wsi/wsi_common_x11.<wbr>c | 6 ++++--<br>
1 file changed, 4 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/vulkan/wsi/wsi_common_<wbr>x11.c b/src/vulkan/wsi/wsi_common_<wbr>x11.c<br>
index 158446c..7479f74 100644<br>
--- a/src/vulkan/wsi/wsi_common_<wbr>x11.c<br>
+++ b/src/vulkan/wsi/wsi_common_<wbr>x11.c<br>
@@ -265,7 +265,8 @@ VkBool32 wsi_get_physical_device_xcb_<wbr>presentation_support(<br>
return false;<br>
<br>
if (!wsi_conn->has_dri3) {<br>
- fprintf(stderr, "vulkan: No DRI3 support\n");<br>
+ fprintf(stderr, "vulkan: No DRI3 support detected - required for presentation\n");<br>
+ fprintf(stderr, "Note: Buggy applications may crash, please report to vendor\n");<br>
return false;<br>
}<br>
<br>
@@ -313,7 +314,8 @@ x11_surface_get_support(<wbr>VkIcdSurfaceBase *icd_surface,<br>
return VK_ERROR_OUT_OF_HOST_MEMORY;<br>
<br>
if (!wsi_conn->has_dri3) {<br>
- fprintf(stderr, "vulkan: No DRI3 support\n");<br>
+ fprintf(stderr, "vulkan: No DRI3 support detected - required for presentation\n");<br>
+ fprintf(stderr, "Note: Buggy applications may crash, please report to vendor\n");<br>
*pSupported = false;<br>
return VK_SUCCESS;<br>
}<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.9.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>