<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 16, 2017 at 1:13 AM, Topi Pohjolainen <span dir="ltr"><<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">which is not applicable for "all slices at each lod". Current<br>
logic makes one to believe it has some purpose. When miptree<br>
layout is calculated brw_miptree_layout_texture_<wbr>array() sets<br>
the qpitch unconditionally but later on ignores it altogether<br>
for ALL_SLICES_AT_EACH_LOD.<br>
<br>
Signed-off-by: Topi Pohjolainen <<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a>><br>
---<br>
src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c | 8 +++++++-<br>
1 file changed, 7 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
index 606d4c2..825c6a0 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
@@ -1901,7 +1901,13 @@ intel_hiz_miptree_buf_create(<wbr>struct brw_context *brw,<br>
buf-><a href="http://aux_base.bo" rel="noreferrer" target="_blank">aux_base.bo</a> = buf->mt->bo;<br>
buf->aux_base.size = buf->mt->total_height * buf->mt->pitch;<br>
buf->aux_base.pitch = buf->mt->pitch;<br>
- buf->aux_base.qpitch = buf->mt->qpitch;<br>
+<br>
+ /* On gen6 hiz is unconditionally laid out packing all slices<br>
+ * at each level-of-detail (LOD). This means there is no valid qpitch<br>
+ * setting. In fact, this is ignored when hardware is setup - there is no<br>
+ * hardware qpitch setting of hiz on gen6.<br>
+ */<br>
+ buf->aux_base.qpitch = 0;<br>
<br>
return buf;<br>
}<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.5.5<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>