<div dir="ltr"><div>Cc: "13.0 17.0" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>><br>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 20, 2017 at 9:31 AM, Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Blorp can deal with depth/stencil surfaces blits/copies without the<br>
render target requirement. Also having both render target and<br>
depth/stencil requirement is incompatible from isl's point of view.<br>
<br>
This fixes an image creation issue in the high level quality settings<br>
of the Unity3D player, which requires a depth texture with src/dst<br>
transfer & 4x multisampling.<br>
<br>
</span>v2: Simply aspect checking condition (Jason)<br>
<span class=""><br>
Signed-off-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a><wbr>><br>
---<br>
</span> src/intel/vulkan/anv_image.c | 7 +++++--<br>
 1 file changed, 5 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c<br>
index 9e5cebe188..12cca67a98 100644<br>
--- a/src/intel/vulkan/anv_image.c<br>
+++ b/src/intel/vulkan/anv_image.c<br>
@@ -75,8 +75,11 @@ choose_isl_surf_usage(<wbr>VkImageUsageFlags vk_usage,<br>
<span class="">       isl_usage |= ISL_SURF_USAGE_TEXTURE_BIT;<br>
    }<br>
<br>
-   if (vk_usage & VK_IMAGE_USAGE_TRANSFER_DST_<wbr>BIT) {<br>
-      /* blorp implements transfers by rendering into the destination image. */<br>
+   if (vk_usage & VK_IMAGE_USAGE_TRANSFER_DST_<wbr>BIT &&<br>
</span>+       aspect == VK_IMAGE_ASPECT_COLOR_BIT) {<br>
<div class="HOEnZb"><div class="h5">+      /* blorp implements transfers by rendering into the destination image.<br>
+       * Only request this with color images, as we deal with depth/stencil<br>
+       * formats differently. */<br>
       isl_usage |= ISL_SURF_USAGE_RENDER_TARGET_<wbr>BIT;<br>
    }<br>
<br>
--<br>
2.11.0<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div>