<div dir="ltr">On 20 January 2017 at 17:06, Christian Gmeiner <<a href="mailto:christian.gmeiner@gmail.com" target="_blank">christian.gmeiner@gmail.com</a>> wrote: <div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Rhys, 2017-01-19 7:02 GMT+01:00 Rhys Kidd <<a href="mailto:rhyskidd@gmail.com">rhyskidd@gmail.com</a>>: > Use of unsigned loop control variable with '>= 0' would lead to infinite loop. > > Reported by clang: > > etnaviv_compiler.c:1024:39: warning: comparison of unsigned expression >= 0 is > always true [-Wtautological-compare] > for (unsigned sp = c->frame_sp; sp >= 0; sp--) > ~~ ^ ~ > > Signed-off-by: Rhys Kidd <<a href="mailto:rhyskidd@gmail.com">rhyskidd@gmail.com</a>> > --- > src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > I compile tested etnaviv but have not functionally tested on real hardware. > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c b/src/gallium/drivers/etnaviv/etnaviv_compiler.c > index 59e1452..f1c6787 100644 > --- a/src/gallium/drivers/etnaviv/etnaviv_compiler.c > +++ b/src/gallium/drivers/etnaviv/etnaviv_compiler.c > @@ -1021,7 +1021,7 @@ label_mark_use(struct etna_compile *c, struct etna_compile_label *label) > static struct etna_compile_frame * > find_frame(struct etna_compile *c, enum etna_compile_frame_type type) > { > - for (unsigned sp = c->frame_sp; sp >= 0; sp--) > + for (unsigned sp = c->frame_sp + 1; sp-- > 0 ; ) looks quite ugly - I have a better and simpler fix. > if (c->frame_stack[sp].type == type) > return &c->frame_stack[sp]; > > -- > 2.9.3 > ------------8<------------------- Subject: [PATCH] etnaviv: Avoid infinite loop in find_frame() Use of unsigned loop control variable with '>= 0' would lead to infinite loop. Reported by clang: etnaviv_compiler.c:1024:39: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] for (unsigned sp = c->frame_sp; sp >= 0; sp--) ~~ ^ ~ v2: Simply use the same datatype as c->frame_sp is using. Reported-by: Rhys Kidd <<a href="mailto:rhyskidd@gmail.com">rhyskidd@gmail.com</a>> Signed-off-by: Christian Gmeiner <<a href="mailto:christian.gmeiner@gmail.com">christian.gmeiner@gmail.com</a>> --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c b/src/gallium/drivers/etnaviv/etnaviv_compiler.c index 59e1452..dc9af57 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_compiler.c +++ b/src/gallium/drivers/etnaviv/etnaviv_compiler.c @@ -1021,7 +1021,7 @@ label_mark_use(struct etna_compile *c, struct etna_compile_label *label) static struct etna_compile_frame * find_frame(struct etna_compile *c, enum etna_compile_frame_type type) { - for (unsigned sp = c->frame_sp; sp >= 0; sp--) + for (int sp = c->frame_sp; sp >= 0; sp--) if (c->frame_stack[sp].type == type) return &c->frame_stack[sp]; -- 2.9.3 ------------8<------------------- If you are okay with that I will push it in the next days. </blockquote><div> Reviewed-by: Rhys Kidd <<a href="mailto:rhyskidd@gmail.com">rhyskidd@gmail.com</a>> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> greets -- Christian Gmeiner, MSc <a href="https://www.youtube.com/user/AloryOFFICIAL" rel="noreferrer" target="_blank">https://www.youtube.com/user/AloryOFFICIAL</a> <a href="https://soundcloud.com/christian-gmeiner" rel="noreferrer" target="_blank">https://soundcloud.com/christian-gmeiner</a> </blockquote></div> </div></div>