<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jan 25, 2017 at 1:25 PM, Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div class="m_-1883902303568616599moz-cite-prefix">Yes, we have
VkPhysicalDeviceFeatures.<wbr>multiDrawIndirect disabled for now.<br>
I was going to look at that in another series, given that this one
didn't break anything in the CI.<br></div></div></blockquote><div><br></div><div>Right. That means that we can always set gl_DrawId to zero. However, I'm not convinced that we actually have code to do so. I think the back-end is pulling it out of an input that we don't provide so it's possible that we're getting an undefined value that happens to be zero in your tests. I just wanted you to double check that it really is being defined as zero.<br><br></div><div>--jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><div class="m_-1883902303568616599moz-cite-prefix">
-<br>
Lionel<div><div class="h5"><br>
<br>
On 25/01/17 19:21, Jason Ekstrand wrote:<br>
</div></div></div><div><div class="h5">
<blockquote type="cite">
<div dir="ltr">Is there something we need to do here to plumb
gl_DrawId through correctly? I'm pretty sure we have exactly
zero code for that.<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Jan 25, 2017 at 10:55 AM,
Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a><wbr>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Enables 10
tests from:<br>
<br>
dEQP-VK.draw.shader_draw_para<wbr>meters.*<br>
<br>
Signed-off-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a><wbr>><br>
---<br>
src/intel/vulkan/anv_device.<wbr>c | 4 ++++<br>
src/intel/vulkan/anv_<wbr>pipeline.c | 1 +<br>
2 files changed, 5 insertions(+)<br>
<br>
diff --git a/src/intel/vulkan/anv_device.<wbr>c
b/src/intel/vulkan/anv_device.<wbr>c<br>
index b24949c5f4..115f011705 100644<br>
--- a/src/intel/vulkan/anv_device.<wbr>c<br>
+++ b/src/intel/vulkan/anv_device.<wbr>c<br>
@@ -268,6 +268,10 @@ static const VkExtensionProperties
device_extensions[] = {<br>
.extensionName = VK_KHR_MAINTENANCE1_EXTENSION_<wbr>NAME,<br>
.specVersion = 1,<br>
},<br>
+ {<br>
+ .extensionName = VK_KHR_SHADER_DRAW_PARAMETERS_<wbr>EXTENSION_NAME,<br>
+ .specVersion = 1,<br>
+ }<br>
};<br>
<br>
static void *<br>
diff --git a/src/intel/vulkan/anv_pipelin<wbr>e.c
b/src/intel/vulkan/anv_pipelin<wbr>e.c<br>
index 2060c6d2f6..ca3823c2b6 100644<br>
--- a/src/intel/vulkan/anv_pipelin<wbr>e.c<br>
+++ b/src/intel/vulkan/anv_pipelin<wbr>e.c<br>
@@ -127,6 +127,7 @@ anv_shader_compile_to_nir(stru<wbr>ct
anv_device *device,<br>
const struct nir_spirv_supported_extensions
supported_ext = {<br>
.float64 = device->instance->physicalDevi<wbr>ce.info.gen
>= 8,<br>
.tessellation = true,<br>
+ .draw_parameters = true,<br>
};<br>
<br>
nir_function *entry_point =<br>
<span class="m_-1883902303568616599HOEnZb"><font color="#888888">--<br>
2.11.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote>
</div>
<br>
</div>
</blockquote>
<p><br>
</p>
</div></div></div>
</blockquote></div><br></div></div>