<div dir="ltr"><div><div>Oops...<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div>Cc: "17.0" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>><br><div><div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 25, 2017 at 7:28 AM, Iago Toral Quiroga <span dir="ltr"><<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">According to GL_KHR_vulkan_glsl, the signature of subpassLoad() is:<br>
<br>
gvec4 subpassLoad(gsubpassInput subpass);<br>
gvec4 subpassLoad(gsubpassInputMS subpass, int sample);<br>
<br>
So the multisampled case always receives an explicit sample index that we<br>
should use. The current implementation was ignoring this parameter<br>
and using gl_SampleID value instead.<br>
<br>
Fixes:<br>
dEQP-VK.pipeline.multisample_<wbr>shader_builtin.sample_id.*<br>
---<br>
src/intel/vulkan/anv_nir_<wbr>lower_input_attachments.c | 5 +----<br>
1 file changed, 1 insertion(+), 4 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_nir_<wbr>lower_input_attachments.c b/src/intel/vulkan/anv_nir_<wbr>lower_input_attachments.c<br>
index 1d6f727..244e7ff 100644<br>
--- a/src/intel/vulkan/anv_nir_<wbr>lower_input_attachments.c<br>
+++ b/src/intel/vulkan/anv_nir_<wbr>lower_input_attachments.c<br>
@@ -100,11 +100,8 @@ try_lower_input_load(nir_<wbr>function_impl *impl, nir_intrinsic_instr *load)<br>
<br>
if (image_dim == GLSL_SAMPLER_DIM_SUBPASS_MS) {<br>
tex->op = nir_texop_txf_ms;<br>
-<br>
- nir_ssa_def *sample_id =<br>
- nir_load_system_value(&b, nir_intrinsic_load_sample_id, 0);<br>
tex->src[2].src_type = nir_tex_src_ms_index;<br>
- tex->src[2].src = nir_src_for_ssa(sample_id);<br>
+ tex->src[2].src = load->src[1];<br>
}<br>
<br>
nir_ssa_dest_init(&tex->instr, &tex->dest, 4, 32, NULL);<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div></div></div></div></div>