<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Jan 26, 2017 6:03 AM, "Lionel Landwerlin" <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="quoted-text">On 26/01/17 13:43, Eric Engestrom wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thursday, 2017-01-26 11:27:00 +0000, Lionel Landwerlin wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Fixes:<br>
    dEQP-VK.api.descriptor_pool.ou<wbr>t_of_pool_memory<br>
<br>
Signed-off-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a><wbr>><br>
</blockquote>
Reviewed-by: Eric Engestrom <<a href="mailto:eric.engestrom@imgtec.com" target="_blank">eric.engestrom@imgtec.com</a>><br>
<br>
But is there any reason not to add support for all the other errors in<br>
vulkan.h as well?<br>
<br>
>From core vulkan, these are also missing:<br>
- VK_ERROR_FEATURE_NOT_PRESENT<br>
- VK_ERROR_TOO_MANY_OBJECTS<br>
- VK_ERROR_FORMAT_NOT_SUPPORTED<br>
<br>
and from the extensions:<br>
- VK_ERROR_SURFACE_LOST_KHR<br>
- VK_ERROR_NATIVE_WINDOW_IN_USE_<wbr>KHR<br>
- VK_ERROR_INCOMPATIBLE_DISPLAY_<wbr>KHR<br>
- VK_ERROR_VALIDATION_FAILED_EXT<br>
- VK_ERROR_INVALID_SHADER_NV<br>
<br>
I can understand not having the extensions ones until we implement each<br>
extension, but I'd be in favour of keeping this list in sync with vulkan.h,<br>
so as not to forget.<br>
<br>
I can't see any reason not to have the core errors, so I'm assuming these<br>
were just forgotten to be added when vulkan.h got updated.<br>
</blockquote>
<br></div>
Fair comment. Let's wait to see whether Jason has any comment.<br>
Thanks</blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">I agree.  Let's add them all.</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="elided-text">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Cheers,<br>
   Eric<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
  src/intel/vulkan/anv_util.c | 2 ++<br>
  1 file changed, 2 insertions(+)<br>
<br>
diff --git a/src/intel/vulkan/anv_util.c b/src/intel/vulkan/anv_util.c<br>
index 6408ac87c7..5fbc7cc113 100644<br>
--- a/src/intel/vulkan/anv_util.c<br>
+++ b/src/intel/vulkan/anv_util.c<br>
@@ -83,9 +83,11 @@ __vk_errorf(VkResult error, const char *file, int line, const char *format, ...)<br>
     ERROR_CASE(VK_ERROR_LAYER_<wbr>NOT_PRESENT)<br>
     ERROR_CASE(VK_ERROR_<wbr>EXTENSION_NOT_PRESENT)<br>
     ERROR_CASE(VK_ERROR_INCOMPATI<wbr>BLE_DRIVER)<br>
+   ERROR_CASE(VK_ERROR_FRAGMENTE<wbr>D_POOL)<br>
       /* Extension errors */<br>
     ERROR_CASE(VK_ERROR_OUT_OF_DA<wbr>TE_KHR)<br>
+   ERROR_CASE(VK_ERROR_OUT_OF_PO<wbr>OL_MEMORY_KHR)<br>
       default:<br>
        assert(!"Unknown error");<br>
-- <br>
2.11.0<br>
<br>
</blockquote></blockquote>
<br>
</div></blockquote></div><br></div></div></div>