<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jan 26, 2017 at 10:23 AM, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I keep seeing patches like this... is it time to move BITFIELD64_* from<br>
mtypes.h to somewhere in util for more general use?<span class="im HOEnZb"><br></span></blockquote><div><br></div><div>It may be time<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="im HOEnZb">
On 01/26/2017 05:18 AM, Emil Velikov wrote:<br>
> From: Emil Velikov <<a href="mailto:emil.velikov@collabora.com">emil.velikov@collabora.com</a>><br>
><br>
> MSVC warns about implicit conversion as below. Annotate the literal<br>
> appropriately to silence the warning.<br>
><br>
> nir_gather_info.c(249) : warning C4334: '<<' : result of 32-bit shift<br>
> implicitly converted to 64 bits (was 64-bit shift intended?)<br>
><br>
> Signed-off-by: Emil Velikov <<a href="mailto:emil.velikov@collabora.com">emil.velikov@collabora.com</a>><br>
> ---<br>
>  src/compiler/nir/nir_gather_<wbr>info.c | 2 +-<br>
>  1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/src/compiler/nir/nir_gather_<wbr>info.c b/src/compiler/nir/nir_gather_<wbr>info.c<br>
> index 35a1ce4dec..0c70787252 100644<br>
> --- a/src/compiler/nir/nir_gather_<wbr>info.c<br>
> +++ b/src/compiler/nir/nir_gather_<wbr>info.c<br>
> @@ -246,7 +246,7 @@ gather_intrinsic_info(nir_<wbr>intrinsic_instr *instr, nir_shader *shader)<br>
>     case nir_intrinsic_load_tess_level_<wbr>outer:<br>
>     case nir_intrinsic_load_tess_level_<wbr>inner:<br>
>        shader->info->system_values_<wbr>read |=<br>
> -         (1 << nir_system_value_from_<wbr>intrinsic(instr->intrinsic));<br>
> +         (1ull << nir_system_value_from_<wbr>intrinsic(instr->intrinsic));<br>
>        break;<br>
><br>
>     case nir_intrinsic_end_primitive:<br>
><br>
<br>
</span><div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>