<div dir="ltr">Did we actually end up needing this? After you got your gl_DrawId issues sorted, were you ever able to get element 33 to work? The Sky Lake docs say it should...<br><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 31, 2017 at 7:00 AM, Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a><wbr>><br>
---<br>
src/intel/vulkan/anv_device.c | 4 ++--<br>
src/intel/vulkan/anv_private.h | 2 +-<br>
src/intel/vulkan/genX_<wbr>pipeline.c | 2 +-<br>
3 files changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_device.<wbr>c b/src/intel/vulkan/anv_device.<wbr>c<br>
index 27f06ac02c..3403dc126a 100644<br>
--- a/src/intel/vulkan/anv_device.<wbr>c<br>
+++ b/src/intel/vulkan/anv_device.<wbr>c<br>
@@ -562,8 +562,8 @@ void anv_<wbr>GetPhysicalDeviceProperties(<br>
.maxDescriptorSetSampledImages = 256,<br>
.maxDescriptorSetStorageImages = 256,<br>
.<wbr>maxDescriptorSetInputAttachmen<wbr>ts = 256,<br>
- .maxVertexInputAttributes = 32,<br>
- .maxVertexInputBindings = 32,<br>
+ .maxVertexInputAttributes = MAX_VBS,<br>
+ .maxVertexInputBindings = MAX_VBS,<br></blockquote><div><br></div><div>Thank you for switching to the #define. Even if we don't end up dropping to 31 vertex buffers, we should keep these bits of this patch.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
.maxVertexInputAttributeOffset = 2047,<br>
.maxVertexInputBindingStride = 2048,<br>
.maxVertexOutputComponents = 128,<br>
diff --git a/src/intel/vulkan/anv_<wbr>private.h b/src/intel/vulkan/anv_<wbr>private.h<br>
index 0cc6550a40..926b8d799f 100644<br>
--- a/src/intel/vulkan/anv_<wbr>private.h<br>
+++ b/src/intel/vulkan/anv_<wbr>private.h<br>
@@ -87,7 +87,7 @@ extern "C" {<br>
*/<br>
#define ANV_HZ_FC_VAL 1.0f<br>
<br>
-#define MAX_VBS 32<br>
+#define MAX_VBS 31<br>
#define MAX_SETS 8<br>
#define MAX_RTS 8<br>
#define MAX_VIEWPORTS 16<br>
diff --git a/src/intel/vulkan/genX_<wbr>pipeline.c b/src/intel/vulkan/genX_<wbr>pipeline.c<br>
index 9d28466f79..d3a9d4302e 100644<br>
--- a/src/intel/vulkan/genX_<wbr>pipeline.c<br>
+++ b/src/intel/vulkan/genX_<wbr>pipeline.c<br>
@@ -133,7 +133,7 @@ emit_vertex_input(struct anv_pipeline *pipeline,<br>
VK_IMAGE_ASPECT_COLOR_BIT,<br>
VK_IMAGE_TILING_LINEAR);<br>
<br>
- assert(desc->binding < 32);<br>
+ assert(desc->binding < MAX_VBS);<br>
<br>
if ((elements & (1 << desc->location)) == 0)<br>
continue; /* Binding unused */<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.11.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div></div>