<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Feb 2, 2017 at 3:28 PM, Nanley Chery <span dir="ltr"><<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Feb 02, 2017 at 08:15:30AM -0800, Nanley Chery wrote:<br>
<br>
Polite ping. </blockquote><div><br></div><div>Pong<br><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div><div>This is a bit on the hackish side but I think I'm ok with it given how common of a clear color black is.  Hopefully, we'll come up with something better one day but this is fine for now.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
> Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br>
> ---<br>
>  src/intel/vulkan/anv_blorp.c | 10 ++++++++--<br>
>  1 file changed, 8 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c<br>
> index 2cf972bb61..759d2ae944 100644<br>
> --- a/src/intel/vulkan/anv_blorp.c<br>
> +++ b/src/intel/vulkan/anv_blorp.c<br>
> @@ -1451,9 +1451,15 @@ ccs_resolve_attachment(struct anv_cmd_buffer *cmd_buffer,<br>
>           resolve_op = BLORP_FAST_CLEAR_OP_RESOLVE_<wbr>FULL;<br>
>        } else if (att_state->fast_clear) {<br>
>           /* We don't know what to do with clear colors outside the render<br>
> -          * pass.  We need a partial resolve.<br>
> +          * pass.  We need a partial resolve. Only transparent black is<br>
> +          * built into the surface state object and thus no resolve is<br>
> +          * required for this case.<br>
>            */<br>
> -         resolve_op = BLORP_FAST_CLEAR_OP_RESOLVE_<wbr>PARTIAL;<br>
> +         if (att_state->clear_value.color.<wbr>uint32[0] ||<br>
> +             att_state->clear_value.color.<wbr>uint32[1] ||<br>
> +             att_state->clear_value.color.<wbr>uint32[2] ||<br>
> +             att_state->clear_value.color.<wbr>uint32[3])<br>
> +            resolve_op = BLORP_FAST_CLEAR_OP_RESOLVE_<wbr>PARTIAL;<br>
>        } else {<br>
>           /* The image "natively" supports all the compression we care about<br>
>            * and we don't need to resolve at all.  If this is the case, we also<br>
> --<br>
> 2.11.0<br>
><br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>