<div dir="ltr">LGTM :)<div><br></div><div>Reviewed-by: Plamena Manolova <<a href="mailto:plamena.manolova@intel.com">plamena.manolova@intel.com</a>> </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 2, 2017 at 12:27 PM, Tapani Pälli <span dir="ltr"><<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Earlier changes introduced is_ycrcb flag which checks the component<br>
order of u and v components. Condition for setting the flag was<br>
incorrect, with ycrcb we are supposed to have cr before cb.<br>
<br>
This patch (together with a fix in our gralloc) fixes corrupted<br>
rendering from 'test-opengl-gl2_yuvtex' native test and corrupted<br>
gallery thumbnail in application switcher on Android-IA.<br>
<br>
Fixes: 51727b1cf57e8c4630767eb9ead207<wbr>b102ffa489<br>
Signed-off-by: Tapani Pälli <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>><br>
---<br>
src/egl/drivers/dri2/platform_<wbr>android.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/egl/drivers/dri2/<wbr>platform_android.c b/src/egl/drivers/dri2/<wbr>platform_android.c<br>
index 36bd119..511b696 100644<br>
--- a/src/egl/drivers/dri2/<wbr>platform_android.c<br>
+++ b/src/egl/drivers/dri2/<wbr>platform_android.c<br>
@@ -629,7 +629,7 @@ droid_create_image_from_prime_<wbr>fd_yuv(_EGLDisplay *disp, _EGLContext *ctx,<br>
* so they can be interpreted as offsets. */<br>
offsets[0] = (size_t)ycbcr.y;<br>
/* We assume here that all the planes are located in one DMA-buf. */<br>
- is_ycrcb = (size_t)ycbcr.cb < (size_t)<a href="http://ycbcr.cr" rel="noreferrer" target="_blank">ycbcr.cr</a>;<br>
+ is_ycrcb = (size_t)<a href="http://ycbcr.cr" rel="noreferrer" target="_blank">ycbcr.cr</a> < (size_t)ycbcr.cb;<br>
if (is_ycrcb) {<br>
offsets[1] = (size_t)<a href="http://ycbcr.cr" rel="noreferrer" target="_blank">ycbcr.cr</a>;<br>
offsets[2] = (size_t)ycbcr.cb;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.9.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>